Hi Niels, I'm nor very familiar with that portion of the code ... but here are my thoughts.
Well the workflow makes sense: if a rule is deleted or modified that rule is invalidated from the cache. The rule matches and invalidate should probably be done by the rule ID and not the rule itself, so I guess instead of: CachedRuleReader.invalidate(Rule rule) we should probably have something like: CachedRuleReader.invalidate(String id) Regards, Nuno Oliveira On 02-06-2017 12:46, Niels Charlier wrote:
Hello Nuno, Another change I have been asked to make in geofence, is that rules in the cache would automatically invalidated when they are changed. I have looked at the code, and I have an idea how to do it, and was wondering if you agree with the approach: 1. write a RuleFilter.matches(Rule rule) method (I think currently rule filters are only used to translate into queries, and there is no way to match a filter with a single rule) 2. write a CachedRuleReader.invalidate(Rule rule) which loops through the whole cache, and invalidates all rule filters that match the rule. 3. write a CachedRuleAdminServiceImpl, that delegates to the normal RuleAdminServiceImpl but calls the above invalidate upon change of an existing rule. Kind Regards Niels
-- == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- AVVERTENZE AI SENSI DEL D.Lgs. 196/2003 Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e -mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.The information in this message and/or attachments, is intended solely for the attention and use of
the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
