Thanks for the review Andrew. I'm happy to go with the second syntax as
well. Looking at the first option again I'm starting to dislike it more :)
I'd also be fine with making the new behavior default on 2.12 if there is a
consensus there. I'll see if others want to weigh in and if there are no
objections to the idea I'll go that route.
As for what the default settings would be im thinking basically mimic
somewhat what the image render does. So perhaps clip set to true and
default to 5 samples to find an internal point?
On Wed, Jun 28, 2017 at 12:59 PM Andrea Aime <[email protected]>
wrote:
> Hi Justin,
> I had a look at the proposal, looks good, I prefer the second syntax, more
> verbose but more clear.
> I would consider making the new centroid behavior a default, at least on
> 2.12.x, with reasonable
> defaults, since the placemarks need normally to be referred to the
> original polygon.
>
> Did not check the patch yet.
>
> Cheers
> Andrea
>
>
> On Wed, Jun 28, 2017 at 4:34 PM, Justin Deoliveira <[email protected]>
> wrote:
>
>> Hi folks,
>>
>> I did an initial sanity check on this change a few months back, and am
>> now ready to push forward so I whipped up a proposal.
>>
>> https://github.com/geoserver/geoserver/wiki/GSIP-160
>>
>> Feedback appreciated.
>>
>> Once there is a concensus on the proposal I’ll update the current branch
>> with documentation updates for KML, and then submit the pull request.
>>
>> Thanks!
>>
>> -Justin
>>
>>
>> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Geoserver-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
