I've updated the proposal with Andrea's suggestion of not passing the context as a parameter and using out of band context like a thread local from Spring Security)
At this point there's not a lot of API change left. Just adding the new interface and expanding which exceptions are thrown. Using AcessControlException as Jody suggested bothers me a bit as the Javadocs tie it to specific other components. I do like the idea of existing exception classes, although a subclass of GeoWebCacheException would probably be less disruptive. On 6/26/17 10:48 AM, Jody Garnett wrote: > Kevin do you want to take this opportunity to make use of spring security? > This proposal has been held open for a while now and I want to make > sure you are not stuck. > > -- > Jody Garnett > > On 19 June 2017 at 14:29, Kevin Smith <smit...@draconic.ca > <mailto:smit...@draconic.ca>> wrote: > > On 6/17/17 10:53 AM, Andrea Aime wrote: > > Hi Kevin, > > the current security mechanism in GeoServer work off an > > Authentication, this one > > seems to be based on Spring own SecurityContext, but the API you > shown > > says that's an Object.... > > Can you clarify how that fits toghether and the rationale behind the > > different approach? > > > > This is the API for upstream GeoWebCache and I didn't want to unduly > restrict future development there. I'm happy to consider making > Spring > Security part of the GWC API, but being flexible seemed like a better > starting point for discussion. > > -- > Kevin Michael Smith > <smit...@draconic.ca <mailto:smit...@draconic.ca>> > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Geowebcache-devel mailing list > geowebcache-de...@lists.sourceforge.net > <mailto:geowebcache-de...@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/geowebcache-devel > <https://lists.sourceforge.net/lists/listinfo/geowebcache-devel> > > -- Kevin Michael Smith <smit...@draconic.ca>
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
