On Mon, Nov 20, 2017 at 10:21 AM, Mauro Bartolomeoli <
[email protected]> wrote:
> Hi,
> there is an issue in the NewLayerPage UI, where a couple of options are
> nade visible for specific datastores.
> In particular there is a bug preventing the "Configure cascaded stored
> query..." for WFSDataStore to appear.
> This happens because the option visibility is based on a <datastore>
> instanceof WFSDataStore condition, that does not match because the
> datastore is wrapped by a RetypingDataStore.
>
> Long story short, we should allow unwrapping those kind of datastores in a
> generic way, in my opinion.
>
> My idea would be to introduce a WrappingDataStore interface with a single
> getWrapped method that would be implemented by RetypingDataStore (and
> others).
> Any opinion on this?
>
Something like DecoratingDataStore
<https://github.com/geoserver/geoserver/blob/6058e38a0c74247ee6fea3db81c3aecbca1f40d2/src/main/src/main/java/org/geoserver/security/decorators/DecoratingDataStore.java#L25-L24>
you
mean? :-)
The only annoying bit is that it's in the security package, not the most
intuitive place. I see there is an old TODO about
moving that class back in GeoTools. Could be done using the usual "move,
extend old from new, and deprecate old" strategy, and moving
all implementors to the new base class to avoid extra deprecations.
Cheers
Andrea
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
