On 13/03/18 13:01, Torben Barsballe wrote:
large concatenated string blocks indented to be more readable

Especially XML documents included in code, such as those used in test fixtures. My workaround before I started using @formatter:off was trailing // comments to defeat the Eclipse formatter.

    - Looking at some of the changes made, we get stuff like this:
     String groupSearchFilter; //more appropriate name would be
groupMembershipFilter - XStream backwards compatibility
becoming:
      String
          groupSearchFilter; // more appropriate name would be
    groupMembershipFilter - XStream backwards
      // compatibility
    Which seems to be pretty bad formatting. So that is a mark against the
    google formatter.

Yes, that is terrible.

Kind regards,

--
Ben Caradoc-Davies <b...@transient.nz>
Director
Transient Software Limited <https://transient.nz/>
New Zealand

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to