Hi Matthew,
proposals should definitely not be written using a proprietary tools such
as MS Word ;-)
Proposals are normally written in the wiki, see
https://github.com/geoserver/geoserver/wiki/Proposals
If that's not possible for you, write them in a mail directly instead.
I see my initial feedback has not been incorporated in it, let met add it
again:
----------
Given the way things are configured, maybe you need to do the opposite,
keep the UI you propose, but key dimensions in the metadata map using the
published name, and have in the dimension configuration a "nativeName"
instead. This also matches how layer renaming facilities work, the layer
has the published name, inside ResourceInfo there is a nativeName.
Overall this is a configuration change, so besides resourcing the actual
coding, you'll have to write a GSIP, see
http://docs.geoserver.org/latest/en/developer/policies/gsip.html
The pull request should follow these rules:
https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md
About where the computation happens, most of the action happens in methods
around this class:
https://github.com/geoserver/geoserver/blob/master/src/wms/
src/main/java/org/geoserver/wms/WMS.java
----------
As reported in the other thread proposing support for SLD in GeoPacakge,
proposal have two reasons to exist,
one is to make sure that the community (the PSC in particular) is ok with
the direction you're going, and second,
ensure that there is resourcing to back their development. This topic is
also covered here:
https://github.com/geoserver/geoserver/wiki/Successfully-requesting-and-integrating-new-features-and-improvements-in-GeoServer
I know it can be hard, but it's how all config changes are done, none
excluded, so it's at least fair.
Cheers
Andrea
On Tue, Mar 20, 2018 at 4:08 PM, Matthew Campbell <[email protected]> wrote:
> Good morning,
>
> I’ve written up a proposal for changes to GeoServer which I believe will
> improve GeoServer and fix a error which happens when dealing with FMRC as
> UCAR implements their runtime dimension name.
>
> I don’t have all the pieces yet on how to go about implementing, and I
> hope you’ll be able to help me find ultimately the correct path of
> implementation.
>
>
>
>
> Thank you for your time,
> Matt Campbell
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
