Hum... maybe there is a pattern. There are various randomly failing tests that seem to be related to truncation/seeding, there is one in GWC, one in GWC, believe disk quota related, where Torben recently added a delay, and then this one... I believe that truncation runs asynch in a thread pool, so to be reliable the tests should wait for it to complete the job.... do we have any notifications that can be used to reliably wait for that to happen in the test?
Cheers Andrea On Wed, Nov 7, 2018 at 2:14 AM Kevin Smith <smit...@draconic.ca> wrote: > I'm cross posting to geowebcache-devel in case there's anyone who isn't > following geoserver-devel who has an interest in GWC S3. > > On 2018-11-05 03:17 AM, Niels Charlier wrote: > > OK, so it's entirely random... peculiar. I'd suggest to make a JIRA issue > out of it and disable this specific method for now. > > Yes, better we keep what tests we can working although I worry about it > getting @Ignored and then, ignored in perpetuity. It looks like there are > a couple of tests in the same suite that fail. > testTruncateOptimizationIfNoListeners > and testTruncateShortCutsIfNoTilesInGridsetPrefix. They both appear to > be tests for optimizations when doing truncation and appear to have been > written by Gabriel back when he first created the S3 store 4 years ago. > > On 05/11/2018 12:11, Andrea Aime wrote: > > Hi Niels, > I'm talking about the official jenkins build server. The test fails every > few days, across branches, it's a random failure, e.g.: > > https://build.geoserver.org/job/geowebcache-master/2030/ > https://build.geoserver.org/view/geowebcache/job/geowebcache-1.14.x/31 > https://build.geoserver.org/view/geowebcache/job/geowebcache-1.14.x/29 > > Cheers > Andrea > > > On Mon, Nov 5, 2018 at 11:26 AM Niels Charlier <ni...@scitus.be> wrote: > >> This is only failing on AppVeyor right? I didn't write the test, I made >> an offline version of an existing unit test, and this seems to work fine >> locally and on travis. >> The fact that it doesn't work seems to point out to a problem that needs >> to be resolved. >> >> However, I don't even fully understand what the idea is of this >> particular test method. It seems to expect a delete operation to fail but >> it succeeds in this particular case. I was hoping the original author or >> someone more familiar with this part of geowebcache could help figuring out >> what is going on (see >> https://github.com/DOV-Vlaanderen/geowebcache/commits/master/geowebcache/s3storage/src/test/java/org/geowebcache/s3 >> for its history). >> >> You can disable it, but then we will go back to the integration test >> never being run automatically, which will make the module less robust. >> Optionally, we could also override only this specific method in the offline >> test to disable it, until the mystery can be resolved. >> >> Regards >> >> Niels >> On 01/11/2018 18:35, Andrea Aime wrote: >> >> The test in question keeps on failing. I'm cc'ing the original author, maybe >> he can help. >> >> In case we get nothing, shall we disable it? >> >> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 14.798 sec >> <<< FAILURE! >> testTruncateShortCutsIfNoTilesInGridsetPrefix(org.geowebcache.s3.OfflineS3BlobStoreIntegrationTest) >> Time elapsed: 0.102 sec <<< FAILURE! >> java.lang.AssertionError >> at org.junit.Assert.fail(Assert.java:86) >> at org.junit.Assert.assertTrue(Assert.java:41) >> at org.junit.Assert.assertFalse(Assert.java:64) >> at org.junit.Assert.assertFalse(Assert.java:74) >> at >> org.geowebcache.s3.AbstractS3BlobStoreIntegrationTest.testTruncateShortCutsIfNoTilesInGridsetPrefix(AbstractS3BlobStoreIntegrationTest.java:352) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at >> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) >> at >> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) >> at >> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) >> at >> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) >> at >> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) >> at >> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) >> at >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) >> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) >> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) >> at >> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) >> at >> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) >> at org.junit.runners.ParentRunner.run(ParentRunner.java:309) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at >> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) >> at >> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) >> at >> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) >> at >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) >> at >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) >> >> >> Cheers >> >> Andrea >> >> == GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf >> Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa >> (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 >> http://www.geo-solutions.it http://twitter.com/geosolutions_it >> ------------------------------------------------------- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify us immediately by >> telephone or e-mail.* >> >> > > -- > > Regards, Andrea Aime == GeoServer Professional Services from the experts! > Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime > @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 > Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 > 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > > > > > > _______________________________________________ > Geoserver-devel mailing > listGeoserver-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/geoserver-devel > > > -- > Kevin Michael Smith<smit...@draconic.ca> <smit...@draconic.ca> > > _______________________________________________ > Geowebcache-devel mailing list > geowebcache-de...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geowebcache-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- *Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.*
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
