Hi Jody,
I didn't know this module. I've just had a look at it. And of course,
you're right, it allows you to edit a template and create a new one, so
yes, it does the job.
Quite handy extension, nice to know its existence. You're right, I'd
probably not have written template-editor extension if I had known this.
I'd say there are some differences though:
1. template-editor deals only with templates. You might not want to
give your users access to all the files in the datadir. For
instance, editing/removing a layer.xml file might not be the best
idea. Or, the security config. While access to template files for
all users allowed to edit a layer seems quite legit.
2. template-editor shows the header, content and footer templates on
the same page. I find it rather practical when editing a template,
even though you often mostly deal with ceontent.ftl
3. template-editor is less low-level. You don't have to know how the
datadir is organized. The entrypoint it a table listing workspace,
datastore and layer, like the LayerPage so you can choose at which
level you want to work. Then you get to the edit page show in the
screenshot.
4. When editing templates for a layer, it gives you the available
attributes. I found this quite handy.
So I'd say it is more specific, but a little bit more focused on
template edition. And much less an admin tool.
I was also considering on the medium term to replace the textareas by an
html editor. Why not some completion, too ?
*Jean Pommier -- pi-Geosolutions*
Ingénieur, consultant indépendant
Tél. : (+33) 6 09 23 21 36
E-mail : [email protected]
Web : www.pi-geosolutions.fr
Le 13/05/2019 à 22:57, Jody Garnett a écrit :
I am not sure this is needed Jean, the web-resource
<https://github.com/geoserver/geoserver/tree/master/src/community/web-resource>
community module offers editing. If you are game I would love to pick
this module up as a supported extension.
Can you try the above community module and write back what you think?
--
Jody Garnett
On Mon, 13 May 2019 at 14:18, Jean Pommier
<[email protected]
<mailto:[email protected]>> wrote:
Hi,
I'd like to propose a template editor module for integration into
community modules.
It is something I wrote some time ago. I've updated it so it works
on 2.15 branch (so I expect it will also on master, or will with
minor changes)
It is quite basic for now, but serves its purpose: offering a UI
to edit the freemarker templates. For now, it supports only the
header, content and footer template files (the ones useful for WMS
getfeatureinfo). It allows to edit them at workspace, datastore or
layer level.
I've joined a screenshot of the edition page.
Are you OK with it ? If so, I'll need some commit access (or I can
make a PR)
Best regards,
Jean
--
*Jean Pommier -- pi-Geosolutions*
Ingénieur, consultant indépendant
Tél. : (+33) 6 09 23 21 36
E-mail : [email protected] <mailto:[email protected]>
Web : www.pi-geosolutions.fr <http://www.pi-geosolutions.fr>
_______________________________________________
Geoserver-devel mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
