Hi Andrea, I sent an individual CLA to [email protected] on May 5th, mentioning GeoServer project. If you like I can send it to you, too.
I ran the tests and fixed one that broke because of link order changes (locally, anyway). I have fixed the issues you mentioned, specifically the line ending problem in the html file and the decoding of utf-8 "=" characters in .properties files (the latter was a bug in NetBeans). Also, I added a comparable order property to the preview format links, and sort on that value after retrieving the beans. I created a new feature branch because git was misbehaving on squashes, and once you are satisfied I will squash it into master for a pull request. Here's the new feature branch comparison with master: https://github.com/geoserver/geoserver/compare/master...prushforth:preview-format-extension2 Thanks, Peter On Fri, May 17, 2019 at 2:39 AM Andrea Aime <[email protected]> wrote: > On Fri, May 17, 2019 at 4:10 AM Peter Rushforth <[email protected]> > wrote: > >> >> Peter Rushforth <[email protected]> >> 9:58 PM (7 minutes ago) >> to geoserver-devel >> Hi, >> >> I'm new to this list, so first step is to introduce myself. >> >> My name is Peter and I am a geospatial developer with a strong interest >> in mapping standards. I've been working on a format that we call Map >> Markup Language for a while, and my organization sponsored development of >> the MapML Community Module. >> >> I would like to continue development of that module. In that regard, I >> have been consulting with Chris Hodgson about developing an extension point >> to GeoServer that would allow people who choose to install the MapML >> Community Module to have easy access to links to map previews. >> > > Hi Peter, welcomed. > In order to contribute you have to sign and send the OSGeo CLA, as per out > contribution guidelines: > https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md > I don't see a CLA on file. You might already have done so, sometimes it > takes a while before the CLAs should up on archive. Let us know. > > >> What we want to propose is to allow extension of the "Common Formats" >> field to allow a module like our own to add to the list of links to common >> formats. >> >> The idea is to enable extension via beans in the spring application >> context of the extension to be found by the preview page and placed in that >> list. The default set of links (that is, the links that are already there) >> would not change. >> [image: image.png] >> > > The list was meant to be a set of formats that most users care for (the > most important ones), it's now outdated, KML should probably be removed and > replaced by GeoJSON. > I don't mind having it extensible. Hopefully the extension point is not > going to get used much, if we end up with 20 formats in the common list, > well, they are not common anymore, they become "most of the formats" :-D > >> >> I have got a feature branch that contains the required / proposed >> changes, if you would have a look and let me know what you think and what's >> the next step for us, that would be awesome. Hopefully we have gone about >> this the right way, please let me know. >> >> https://github.com/prushforth/geoserver/tree/preview-format-extension >> (there're a few too many commits in that branch, I tried to squash them >> but they refused. When it comes to a pull request I can squash them there, >> I believe). >> > > Ability to squash depends on merges, if you do merges in between your > commit I don't think you can squash them anymore. Otherwise it should be > fine. > > Had a quick look on one of the commits (until you do a PR it's hard to see > the full set of changes) and added a few comments. > > One thing that I'm missing (and maybe I've just overlooked it) is a way to > sort the formats into a stable order. If it's missing, then the > formats would show up in different order depending on the installation > details, JVM used and so on. Chaos on one of the most used pages. > That needs to be handled :-D > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* >
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
