Hi community.

   I'm reproducing an exception using Complex Features and WFS GeoJSONBuilder 
on Geoserver 2.16 (master) with this stack trace:
   net.sf.json.JSONException: Nesting too deep.
       at net.sf.json.util.JSONBuilder.push(JSONBuilder.java:270)
       at net.sf.json.util.JSONBuilder.object(JSONBuilder.java:240)
       at 
org.geoserver.wfs.json.ComplexGeoJsonWriter.encodeFeature(ComplexGeoJsonWriter.java:105)
       at 
org.geoserver.wfs.json.ComplexGeoJsonWriter.encodeComplexAttribute(ComplexGeoJsonWriter.java:563)
       at 
org.geoserver.wfs.json.ComplexGeoJsonWriter.encodeProperty(ComplexGeoJsonWriter.java:409)
       at 
org.geoserver.wfs.json.ComplexGeoJsonWriter.encodeProperty(ComplexGeoJsonWriter.java:383)
       at java.util.ArrayList.forEach(ArrayList.java:1257)

   This exception is not present on previous versions (2.14 for example) and 
looks like we are facing it since now some extra "properties" attributes were 
added to GeoJSON encoding recently.

   Checking for the root problem seems like json-lib JSONBuilder class has a 
hard-coded limit of 20 nested levels as we can see on:

   
https://github.com/aalmiray/Json-lib/blob/master/src/main/java/net/sf/json/util/JSONBuilder.java#L61

   Since we added new levels to GeoJSON encoding it is a good idea to relax a 
bit this limit, but as you can see the problem is this limit is not 
configurable since the static variable is final.  So I see two solutions to 
this:

     * Fork json-lib and relax limit or make it configurable.
     * Use reflection for modify the value at runtime.

   Of course the first solution sounds better since reflection can be 
problematic for some environments (for example blocked by a security manager).
   I currently did a fork relaxing the limit to 5000 in:
   https://github.com/fernandor777/Json-lib/tree/limit-fix-2.4

   So it could be good to discuss the best approach to fix this and, of course, 
to read better ideas from all you.

   Thanks.

   Regards,

   Fernando Mino

   ==

   GeoServer Professional Services from the experts! Visit http://goo.gl/it488V 
for more information.

   ==

   Fernando Mino

   Software Engineer

   GeoSolutions S.A.S.

   Via di Montramito 3/A

   55054  Massarosa (LU)

   Italy

   phone: +39 0584 962313

   fax:     +39 0584 1660272

   http://www.geo-solutions.it

   http://twitter.com/geosolutions_it

   -------------------------------------------------------

   Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 
2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa 
che ogni circostanza inerente alla presente email (il suo contenuto, gli 
eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i 
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per 
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei 
comunque grato se potesse darmene notizia.
   This email is intended only for the person or entity to which it is 
addressed and may contain information that is privileged, confidential or 
otherwise protected from disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or 
the information herein by anyone other than the intended recipient is 
prohibited. If you have received this email by mistake, please notify us 
immediately by telephone or e-mail.
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to