Should we fork the JSON lib into the geoserver repository?

I note that forked jars are a little bit of a bother to track for GeoMesa
(and other eclipse projects) so I would like to confirm that this is just a
GeoServer dependency.
--
Jody Garnett


On Fri, 6 Sep 2019 at 07:21, Simone Giannecchini <
[email protected]> wrote:

> We discussed this internally already and I am fine with this approach.
>
> We also need to talk about long term approach to maintain the JSON lib we
> are talking about.
>
> Regards,
> Simone Giannecchini
> ==
> GeoServer Professional Services from the experts!
> Visit http://bit.ly/gs-services for more information.
> ==
> Ing. Simone Giannecchini
> @simogeo
> Founder/Director
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax:     +39 0584 1660272
> mob:   +39  333 8128928
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
> precisa che ogni circostanza inerente alla presente email (il suo
> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
> This email is intended only for the person or entity to which it is
> addressed and may contain information that is privileged, confidential or
> otherwise protected from disclosure. We remind that - as provided by
> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
> e-mail or the information herein by anyone other than the intended
> recipient is prohibited. If you have received this email by mistake, please
> notify us immediately by telephone or e-mail.
>
>
> On Fri, Sep 6, 2019 at 4:14 PM Nuno Oliveira <
> [email protected]> wrote:
>
>> Hi all,
>> adding a bit more info about this one, this nested JSON limit issue and
>> how to handle has been discussed in this ML:
>>
>> http://osgeo-org.1560.x6.nabble.com/JSON-Nesting-too-deep-exception-due-to-hard-coded-limit-td5409280.html
>>
>> As described in the linked thread, this is not a GeoServer limitation, it
>> is a json-lib limitation, in GeoServer we only need to modify the pom.xml.
>> We forked the lib and implemented the fix discussed on the thread, and
>> make the necessary artifact available for Maven.
>>
>> That say, we need this fix badly on a few downstream projects that will
>> depend on GeoServer 2.16.0.
>> Since this is a very isolated bug fix, which doesn't change any API, he
>> would like to include it on 2.16.0.
>>
>> Any objection?
>>
>> Cheers,
>> Nuno Oliveira
>>
>> On Fri, 2019-09-06 at 15:28 +0200, [email protected] wrote:
>>
>> Hi community,
>>
>> Recently I sent a PR for fixing GEOS-9321 (json nested limit fix) on
>> master.  This fix includes json-lib version upgrade to a forked and fixed
>> new release, since the hard-coded limit resides into this library code.
>> Currently new Json-lib Jar is released into Geosolutions maven server, but
>> the plan is having it on OSGeo maven servers as next step.
>>
>> This is an important fix for complex features usage and for downstream
>> projects, and it is isolated to WFS GeoJSON output max nested objects
>> support.  No format, logic or behavior changes.
>>
>> PR:
>> https://github.com/geoserver/geoserver/pull/3736
>>
>> JIRA issue:
>> https://osgeo-org.atlassian.net/browse/GEOS-9321
>>
>> So I'm asking permission for including this fix into 2.16.0 release
>> branch.
>>
>> Thanks.
>>
>> Regards,
>>
>> Fernando Mino
>>
>> ==
>>
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information.
>>
>> ==
>>
>> Fernando Mino
>>
>> Software Engineer
>>
>> GeoSolutions S.A.S.
>>
>> Via di Montramito 3/A
>>
>> 55054  Massarosa (LU)
>>
>> Italy
>>
>> phone: +39 0584 962313
>>
>> fax:     +39 0584 1660272
>>
>> http://www.geo-solutions.it
>>
>> http://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>>
>> Con riferimento alla normativa sul trattamento dei dati personali (Reg.
>> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
>> precisa che ogni circostanza inerente alla presente email (il suo
>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>
>> This email is intended only for the person or entity to which it is
>> addressed and may contain information that is privileged, confidential or
>> otherwise protected from disclosure. We remind that - as provided by
>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
>> e-mail or the information herein by anyone other than the intended
>> recipient is prohibited. If you have received this email by mistake, please
>> notify us immediately by telephone or e-mail.
>>
>>
>> _______________________________________________
>> Geoserver-devel mailing 
>> [email protected]https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
>> --
>> Regards,
>> Nuno Oliveira
>> ==
>> GeoServer Professional Services from the
>> experts!
>> Visit http://goo.gl/it488V for more information.
>> ==
>>
>> Nuno Miguel Carvalho Oliveira
>> @nmcoliveira
>> Software Engineer
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> 55054  Massarosa (LU)
>> Italy
>> phone: +39 0584 962313
>> fax:      +39 0584 1660272
>> http://www.geo-solutions.ithttp://twitter.com/geosolutions_it
>>
>> -------------------------------------------------------
>>
>> Con riferimento alla normativa sul trattamento dei dati
>> personali (Reg. UE 2016/679 - Regolamento generale sulla
>> protezione dei dati “GDPR”), si precisa che ogni
>> circostanza inerente alla presente email (il suo contenuto,
>> gli eventuali allegati, etc.) è un dato la cui conoscenza
>> è riservata al/i solo/i destinatario/i indicati dallo
>> scrivente. Se il messaggio Le è giunto per errore, è
>> tenuta/o a cancellarlo, ogni altra operazione è illecita.
>> Le sarei comunque grato se potesse darmene notizia.
>>
>> This email is intended only for the person or entity to
>> which it is addressed and may contain information that
>> is privileged, confidential or otherwise protected from
>> disclosure. We remind that - as provided by European
>> Regulation 2016/679 “GDPR” - copying, dissemination or
>> use of this e-mail or the information herein by anyone
>> other than the intended recipient is prohibited. If you
>> have received this email by mistake, please notify
>> us immediately by telephone or e-mail.
>>
>> _______________________________________________
>> Geoserver-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to