Hi Andrea, Ian, thank you for the detailed feedback, proposal updated with your feedback: https://github.com/geoserver/geoserver/wiki/GSIP-178
The pull request was amended accordingly, we moved the enabled and advertised to PublishInfo interface, and indeed it looks better aligned with GeoServer design now: https://github.com/geoserver/geoserver/pull/3807 Can I ask you to revisit your vote? Thank you, Nuno Oliveira On Fri, Oct 4, 2019 at 11:37 AM Ian Turton <[email protected]> wrote: > -0 from me, I defer to Andrea's better understanding of the issues. > > Ian > > On Fri, 4 Oct 2019 at 09:35, Andrea Aime <[email protected]> > wrote: > >> Doh, starting over, got confused by the links. >> >> Sorry I could not participate much to the original discussion, the >> proposal was sent during FOSS4G, and with the >> build server still storming the devel list (I see I added a few comments, >> but I did not understand the proposal well) >> >> For this one, and within the limits of the current implementation (as per >> PR) I have to cast a -1. >> The current implementation changes CatalogInfo with two new bean >> properties, some of them are not making >> sense for all cases, for example, advertised is for OGC services (the >> REST configuration API shows all >> items the admin is allowed to see) , stores are not visible, workspaces >> not directly, >> barring any change in the general GeoServer behavior, advertised will >> never make sense for those. >> >> The default setter implementations in CatalogInfo does nothing, breaking >> the bean behavior pattern >> (a setter has to change the value of the property). >> >> If the getters are to stay there, at the very minimum: >> >> - remove the setters default implementation >> - clearly advertise the enabled/advertised property can be read only >> (it's not common for catalog objects, it will surprise developers and REST >> API users alike) >> - make sure the properties do not end up showing in the REST API for >> objects that have it read only, or change the REST API documentation >> stating >> in which objects the values cannot be changed >> >> Regards >> Andrea >> >> >> On Fri, Oct 4, 2019 at 10:01 AM Andrea Aime <[email protected]> >> wrote: >> >>> Hi Nuno, >>> works for me, +1 >>> >>> Just a note, the proposal talks about displaying "time", but it's really >>> a timestamp >>> >>> Cheers >>> Andrea >>> >>> >>> On Thu, Oct 3, 2019 at 11:04 PM Nuno Oliveira GeoSolutions < >>> [email protected]> wrote: >>> >>>> Dear PSC memebers, >>>> >>>> I would kindly ask you to cast a vote on: >>>> https://github.com/geoserver/geoserver/wiki/GSIP-178 >>>> <https://github.com/geoserver/geoserver/wiki/GSIP-179> >>>> >>>> This thread is for the voting process, the discussion thread is >>>> available here: >>>> >>>> http://osgeo-org.1560.x6.nabble.com/GSIP-178-Extra-metadata-for-single-and-opaque-layers-groups-enabled-and-advertised-td5413735.html#a5413788 >>>> >>>> The proposal links to the relevant JIRA ticket and pull request. >>>> >>>> Thank you, >>>> Nuno Oliveira >>>> >>>> >>>> >>>> -- >>>> Regards, >>>> Nuno Oliveira >>>> == >>>> GeoServer Professional Services from the experts! >>>> Visit http://goo.gl/it488V for more information. >>>> == >>>> >>>> Nuno Miguel Carvalho Oliveira >>>> @nmcoliveira >>>> Software Engineer >>>> >>>> GeoSolutions S.A.S. >>>> Via di Montramito 3/A >>>> 55054 Massarosa (LU) >>>> Italy >>>> phone: +39 0584 962313 >>>> fax: +39 0584 1660272 >>>> >>>> http://www.geo-solutions.it >>>> http://twitter.com/geosolutions_it >>>> >>>> ------------------------------------------------------- >>>> >>>> Con riferimento alla normativa sul trattamento dei dati >>>> personali (Reg. UE 2016/679 - Regolamento generale sulla >>>> protezione dei dati “GDPR”), si precisa che ogni >>>> circostanza inerente alla presente email (il suo contenuto, >>>> gli eventuali allegati, etc.) è un dato la cui conoscenza >>>> è riservata al/i solo/i destinatario/i indicati dallo >>>> scrivente. Se il messaggio Le è giunto per errore, è >>>> tenuta/o a cancellarlo, ogni altra operazione è illecita. >>>> Le sarei comunque grato se potesse darmene notizia. >>>> >>>> This email is intended only for the person or entity to >>>> which it is addressed and may contain information that >>>> is privileged, confidential or otherwise protected from >>>> disclosure. We remind that - as provided by European >>>> Regulation 2016/679 “GDPR” - copying, dissemination or >>>> use of this e-mail or the information herein by anyone >>>> other than the intended recipient is prohibited. If you >>>> have received this email by mistake, please notify >>>> us immediately by telephone or e-mail. >>>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> >>> Regards, Andrea Aime == GeoServer Professional Services from the >>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito >>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: >>> +39 339 8844549 http://www.geo-solutions.it >>> http://twitter.com/geosolutions_it >>> ------------------------------------------------------- *Con >>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail.* >>> >> >> >> -- >> >> Regards, Andrea Aime == GeoServer Professional Services from the experts! >> Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime >> @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 >> Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 >> 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it >> ------------------------------------------------------- *Con riferimento >> alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - >> Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni >> circostanza inerente alla presente email (il suo contenuto, gli eventuali >> allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i >> destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per >> errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le >> sarei comunque grato se potesse darmene notizia. This email is intended >> only for the person or entity to which it is addressed and may contain >> information that is privileged, confidential or otherwise protected from >> disclosure. We remind that - as provided by European Regulation 2016/679 >> “GDPR” - copying, dissemination or use of this e-mail or the information >> herein by anyone other than the intended recipient is prohibited. If you >> have received this email by mistake, please notify us immediately by >> telephone or e-mail.* >> _______________________________________________ >> Geoserver-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > Ian Turton > -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
