Jody, let it slip till next release, don't even waste your time. (btw, the npe was a newly introduced issue of my own, the clean up of null checks is good and verified they were testing for nulls that couldn't happen inside the internal code, not user input of any kind)
On Wed, 20 Nov 2019 at 14:59, Jody Garnett <jody.garn...@gmail.com> wrote: > Gabriel my testing was fine, but I admit to being somewhat hesitant given > fernando's recent trouble. > > I understand you wanting to clean up code. The strategy of removing null > checks that should not happen is always risky (for when they happen). > -- > Jody Garnett > > > On Mon, 18 Nov 2019 at 10:34, Jody Garnett <jody.garn...@gmail.com> wrote: > >> I will test myself locally and get back to you. >> -- >> Jody Garnett >> >> >> On Mon, 18 Nov 2019 at 06:20, Gabriel Roldan <gabriel.rol...@gmail.com> >> wrote: >> >>> Hi all, >>> >>> re-issued GEOS-9191 pr[1] with new test cases to cover the issue that >>> forced us to revert the other one. >>> I'll leave it to you, Jody, to decide whether to include the 2.16.x >>> backport on this release. IMHO it should be safe, and I tested manually >>> with a data directory that has no gwc-layers directory with and without the >>> fix commit and it seems all good. >>> >>> Cheers, >>> Gabriel >>> >>> [1] https://github.com/geoserver/geoserver/pull/3909 >>> [2] >>> https://github.com/geoserver/geoserver/pull/3909/commits/65cc9227b7a9138edb9313784d53e4c718158958 >>> >>> >>> On Mon, 18 Nov 2019 at 05:16, Andrea Aime <andrea.a...@geo-solutions.it> >>> wrote: >>> >>>> Reminder 2, 2.16.1 is a stable series release, so careful about what >>>> you backport >>>> only a few days before the release >>>> >>>> Cheers >>>> Andrea >>>> >>>> On Mon, Nov 18, 2019 at 6:38 AM Jody Garnett <jody.garn...@gmail.com> >>>> wrote: >>>> >>>>> The GeoServer 2.16.2 release is scheduled >>>>> <https://github.com/geoserver/geoserver/wiki/Release-Schedule> for >>>>> this week. If you have any fixes or pull requests this is your reminder :) >>>>> -- >>>>> Jody Garnett >>>>> _______________________________________________ >>>>> Geoserver-devel mailing list >>>>> Geoserver-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>>> >>>> >>>> >>>> -- >>>> >>>> Regards, Andrea Aime == GeoServer Professional Services from the >>>> experts! Visit http://goo.gl/it488V for more information. == Ing. >>>> Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito >>>> 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: >>>> +39 339 8844549 http://www.geo-solutions.it >>>> http://twitter.com/geosolutions_it >>>> ------------------------------------------------------- *Con >>>> riferimento alla normativa sul trattamento dei dati personali (Reg. UE >>>> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>>> precisa che ogni circostanza inerente alla presente email (il suo >>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>>> This email is intended only for the person or entity to which it is >>>> addressed and may contain information that is privileged, confidential or >>>> otherwise protected from disclosure. We remind that - as provided by >>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>>> e-mail or the information herein by anyone other than the intended >>>> recipient is prohibited. If you have received this email by mistake, please >>>> notify us immediately by telephone or e-mail.* >>>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> Gabriel Roldán >>> >> -- Gabriel Roldán
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
