Hi Jody, Seems like I merged the PR and forgot to check the voting process by mistake (sorry!).
Perhaps I should start a thread about the voting, and if the vote fails I will revert the PR. Is this fine? Thanks. Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Fernando Mino Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. From "Jody Garnett" [email protected] To "Nuno Oliveira" [email protected] Cc [email protected],"GeoServer" [email protected] Date Tue, 24 Dec 2019 16:11:04 +0100 Subject Re: [Geoserver-devel] Add per-workspace support for WFS Stored Queries WIP Has this proposal gone ahead? I see no record of it being passed or further voting? https://github.com/geoserver/geoserver/wiki/GSIP-183 -- Jody Garnett On Tue, 12 Nov 2019 at 16:09, Nuno Oliveira <[email protected]> wrote: Hi Fernando, thank you for the proposal. I'm assuming that when creating stored queries (when the per workspace stored queries are activated): * if a virtual service end point is targeted, then the created stored query will belong to that workspace * when the global end point is targeted then the stored query will be global All the rest seems clear to me, +1 Best regards, Nuno Oliveira On Thu, 2019-11-07 at 18:54 +0100, [email protected] wrote: Hi community, Just added GSIP-183 [Add per-workspace support for WFS Stored Queries] for evaluation, discuss and voting: https://github.com/geoserver/geoserver/wiki/GSIP-183 Thanks. Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Fernando Mino Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. From "[email protected]" [email protected] To [email protected] Cc [email protected] Date Thu, 7 Nov 2019 14:22:23 +0100 Subject Re: [Geoserver-devel] Add per-workspace support for WFS Stored Queries WIP Hi Jody, The idea seems straightforward, I am a bit concerned with using the same id in two different workspaces. This seems important to you since you marked it in bold - why? This is for allowing different virtual services to have the freedom to name its own stored queries, without the limit that other workspace already took the desired stored query id. Indeed this is important because is one of the main goals for this PR. It may be more straight forward to only manage the stored queries globally or per-workspace rather than try and combine them all into a single list (and have complexity around ID collisions). The reason for allowing current workspace to see global stored queries is for backward compatibility and the possibility of having shared stores queries between several virtual services instead of declaring it in every workspace. Thanks for your feedback, I'm going to write a GSIP proposal for this improvement. Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Fernando Mino Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. From "Jody Garnett" [email protected] To [email protected] Cc "Geoserver-devel" [email protected] Date Wed, 6 Nov 2019 10:38:33 -0800 Subject Re: [Geoserver-devel] Add per-workspace support for WFS Stored Queries WIP The idea seems straightforward, I am a bit concerned with using the same id in two different workspaces. This seems important to you since you marked it in bold - why? It may be more straight forward to only manage the stored queries globally or per-workspace rather than try and combine them all into a single list (and have complexity around ID collisions). Usual feedback, write up a proposal and be sure to update the documentation. -- Jody Garnett On Wed, 30 Oct 2019 at 11:58, [email protected] <[email protected]> wrote: Hi community, I'm working on adding per-workspace WFS 2.0 Stored queries support. The core concept is that we will allow the creation of stored queries per workspace: * when creating a stored query, if a workspace virtual service end-point is used, then the query will belong to that workspace: + but that query will only be visible \ usable from that workspace virtual end-point * if no workspace virtual service is used, then the stored query will be global In terms of stored queries usage (list stored queries, execute a stored query, etc ...): * when targeting the global GeoServer end-point, only global stored queries will be visible: + hence two stored queries of different workspaces can have the same id * when targeting a workspace virtual service end-point, the workspace stored queries and global stored queries that don't collide (don't have the same id) will be considered: + considering also global queries will allow the definition of more generic stored queries, hence removing the need of duplication + considering global queries will be activated by default, but can be deactivated (flag in the WFS workspace configuration) In terms of backwards compatibility: * global stored queries will be stored as they are now, so no data directory migration need * for backwards compatibility, a flag deactivating per workspace stored queries will be added: + if an user was using a virtual service end-point for creating stored-queries (we can do that now but the stored query will be global anyway), it can use that global flag to deactivate the new functionality I would like to backport this feature, so proposed default behavior is: * Activated by default on master branch. * Deactivated by default on backport branches. Do you have comments, suggestions on this plan? Current PR for master branch, if anyone wants to check/review: https://github.com/geoserver/geoserver/pull/3867 Regards, Fernando Mino == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Fernando Mino Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel -- Regards, Nuno Oliveira == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Nuno Miguel Carvalho Oliveira @nmcoliveira Software Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail. _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
