Hello Peter,
A fix for the tests is on its way (PR is building), but that is also on
the 2.17-SNAPSHOT master branch.
If you want to build in a custom 2.16, you will need some additional
core patches, see:
https://github.com/geoserver/geoserver/pull/3440/commits
Try cherry-picking the first two commits from this PR. That should
normally do the trick.
Let me know how it goes.
Kind Regards
Niels
On 27/01/2020 13:14, Peter Smythe wrote:
Hi Niels
Have you had a chance to progress on this? I have managed to build
the metadata module for v2.17-SNAPSHOT, but I have not had any success
with building it for v2.16.0. Would you be able to give me any
guidance on how to do this?
The maven error message is below.
Thanks
Peter
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile
(default-compile) on project gs-metadata: Compilation failure
[ERROR]
src/community/metadata/src/main/java/org/geoserver/metadata/web/layer/MetadataTabPanel.java:[191,5]
method does not override or implement a method from a supertype
[ERROR]
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile
(default-compile) on project gs-metadata: Compilation failure
src/community/metadata/src/main/java/org/geoserver/metadata/web/layer/MetadataTabPanel.java:[191,5]
method does not override or implement a method from a supertype
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)
Caused by:
org.apache.maven.plugin.compiler.CompilationFailureException:
Compilation failure
src/community/metadata/src/main/java/org/geoserver/metadata/web/layer/MetadataTabPanel.java:[191,5]
method does not override or implement a method from a supertype
at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute
(AbstractCompilerMojo.java:1215)
at org.apache.maven.plugin.compiler.CompilerMojo.execute
(CompilerMojo.java:188)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)
[ERROR]
On Thu, 23 Jan 2020 at 12:01, Niels Charlier <[email protected]
<mailto:[email protected]>> wrote:
Hello Kerstin,
I had a look at it and the test failures can be ignored. They are
faults in the tests rather than in the module itself.
I have some time now and I am going to make an upgrade today or
soon to add the proper packaging configuration and fix the tests
(and add some new features/bug fixes). Of course, this will only
be on master and will take a while to perpetuate in the next
stable release.
Regards
Niels
On 19/01/2020 09:31, Andrea Aime wrote:
On Sat, Jan 18, 2020 at 10:09 PM <[email protected]
<mailto:[email protected]>> wrote:
Hi Niels,
I tried to build the metadata community extension myself
since there is no zip-file available as described here:
https://docs.geoserver.org/latest/en/user/community/metadata/configuration.html#installation
Community modules, if present, are found only in nightly builds:
https://build.geoserver.org/geoserver/master/community-latest/
But, in the case of the metadata module, it's not even there, the
packaging directives are missing. It is not
a requirement to have it for a community module mind, but the
docs are misleading.
I used OpenJDK11 and skipped the tests during maven build.
Afterwards I tried to run it on Tomcat 8.5. As soon as I copy
the gs-metadata-2.17-SNAPSHOT.jar in the
geoserver\WEB-INF\lib folder and restart geoserver, geoserver
is not starting again while logging a bunch of errors.
So I activated the tests while compiling the metadata
extension in case there is an error already while compiling:
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running
org.geoserver.metadata.data.model.ComplexMetaDataMapTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time
elapsed: 0.283 s - in
org.geoserver.metadata.data.model.ComplexMetaDataMapTest
[INFO] Running
org.geoserver.metadata.data.service.ComplexMetadataServiceTest
Jän. 18, 2020 9:28:20 NACHM.
org.geoserver.metadata.data.service.impl.ConfigurationServiceImpl
readConfiguration
SEVERE: Cannot construct instance of
`org.geoserver.metadata.data.dto.impl.MetadataConfigurationImpl`
(although at least one Creator exists): no String-argument
constructor/factory method to deserialize from String value
('klopt-niets-van')
at [Source:
(org.geoserver.platform.resource.FileSystemResourceStore$FileSystemResource$1);
line: 1, column: 1]
com.fasterxml.jackson.databind.exc.MismatchedInputException:
Cannot construct instance of
`org.geoserver.metadata.data.dto.impl.MetadataConfigurationImpl`
(although at least one Creator exists): no String-argument
constructor/factory method to deserialize from String value
('klopt-niets-van')
Any suggestions how I could proceed?
I never used this module personally, but while we wait for Niels
to pick this up:
* Failing tests do not necessarily mean the module won't work
at runtime, community modules don't have their test suite run
during builds, only supported modules do
* In order to work in the war a module does not need just its
generated jars, but also dependencies. See
https://github.com/geoserver/geoserver/blob/master/src/community/metadata/pom.xml
it
depends on more jars, that you might need to add. Looking at
that class, you're probably missing jackson-core and
jackson-annotations (not directly in the pom, it's a
transitive dependency). You might want to collect them using
mvn dependency:collect and see what's missing from the war
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime
@geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A
55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272
mob: +39 339 8844549 http://www.geo-solutions.it
http://twitter.com/geosolutions_it
------------------------------------------------------- /Con
riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei
dati “GDPR”), si precisa che ogni circostanza inerente alla
presente email (il suo contenuto, gli eventuali allegati, etc.) è
un dato la cui conoscenza è riservata al/i solo/i destinatario/i
indicati dallo scrivente. Se il messaggio Le è giunto per errore,
è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is
intended only for the person or entity to which it is addressed
and may contain information that is privileged, confidential or
otherwise protected from disclosure. We remind that - as provided
by European Regulation 2016/679 “GDPR” - copying, dissemination
or use of this e-mail or the information herein by anyone other
than the intended recipient is prohibited. If you have received
this email by mistake, please notify us immediately by telephone
or e-mail./
_______________________________________________
Geoserver-devel mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
