Ian, Jody Thanks a lot for testing investigating the issue! I'll clean up the artifacts and re-run the Jenkins job. I'll keep you posted
On Mon, May 25, 2020 at 9:14 AM Andrea Aime <[email protected]> wrote: > The tagged sources indeed still depend on snapshots: > > https://github.com/geoserver/geoserver/blob/2.16.3/src/pom.xml#L1965 > > I think I know what it is... the build had, what seemed to us, new > parameters that we could not understand: > "Skips the build of GeoTools revision" > "Skips the build of GeoWebCache revision" > Which makes it seem it would rebuild the respective projects. > > Looking at the script, setting them to "skip" actually skips a build of > the projects (and why would we do another build > of them anyways?) but also skips setting gt_tag: > > https://github.com/geoserver/geoserver/blob/master/build/build_release.sh#L147 > > and without gt_tag, the version number is not set later: > > https://github.com/geoserver/geoserver/blob/master/build/build_release.sh#L190 > > Looking at the script history, that section has been there for ages... but > I don't remember seeing the > corresponding parameters in the GeoServer build before: > > [image: image.png] > > Are they new? > > Cheers > Andrea > > > > > > On Mon, May 25, 2020 at 5:24 AM Jody Garnett <[email protected]> > wrote: > >> The release job #2 here: >> https://build.geoserver.org/view/release/job/geoserver-release/2/parameters/ >> >> - Shows GeoTools 22.3 and GeoWebCache 1.16.3 being used. >> >> The console output >> https://build.geoserver.org/view/release/job/geoserver-release/2/consoleFull >> Shows the version numbers getting passed in >> >> Building release with following parameters: >>> branch = 2.16.x >>> revision = f4e92654fa401b15d859db41408928d2307808b7 >>> tag = 2.16.3 >>> geotools = 22.3 >>> geowebcache = 1.16.3 >>> jira id = 16777 >>> distribution = >>> /var/lib/jenkins/workspace/geoserver-release/distribution/2.16.3 >> >> >> While I can see "*updating version numbers from 2.16-SNAPSHOT to 2.16.3" >> *I cannot see the echo statements for gt_version. >> >> And the resulting VERSION.txt ends up with: >> >> *version = 2.16.3* >> *git revision = f4e92654fa401b15d859db41408928d2307808b7* >> *git branch = origin/master* >> *build date = 19-May-2020 15:44* >> *geotools version = 22-SNAPSHOT* >> *geotools revision = f03368333b805e06ab78847391649152fd9f5d67* >> *geowebcache version = 1.16-SNAPSHOT* >> *geowebcache revision = c9c0b778d4df6eb4f334be95811ea315d84e3450/c9c0b* >> *hudson build = -1* >> >> >> -- >> Jody Garnett >> >> >> On Sun, 24 May 2020 at 01:46, Ian Turton <[email protected]> wrote: >> >>> Just downloaded the released version and it seems to have been built >>> from snapshots of GeoTools and GeoWebCache >>> >>> >>> GeoServer Version >>> 2.16.3 >>> Git Revision >>> f4e92654fa401b15d859db41408928d2307808b7 >>> Build Date >>> 19-May-2020 15:44 >>> GeoTools Version >>> 22-SNAPSHOT (rev f03368333b805e06ab78847391649152fd9f5d67) >>> GeoWebCache Version >>> 1.16-SNAPSHOT (rev >>> c9c0b778d4df6eb4f334be95811ea315d84e3450/c9c0b778d4df6eb4f334be95811ea315d84e3450) >>> >>> Ian >>> >>> -- >>> Ian Turton >>> _______________________________________________ >>> Geoserver-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>> >> _______________________________________________ >> Geoserver-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> > > > -- > > Regards, Andrea Aime > > == GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf > Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa > (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 > http://www.geo-solutions.it http://twitter.com/geosolutions_it > ------------------------------------------------------- *Con riferimento > alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - > Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni > circostanza inerente alla presente email (il suo contenuto, gli eventuali > allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i > destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per > errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le > sarei comunque grato se potesse darmene notizia. This email is intended > only for the person or entity to which it is addressed and may contain > information that is privileged, confidential or otherwise protected from > disclosure. We remind that - as provided by European Regulation 2016/679 > “GDPR” - copying, dissemination or use of this e-mail or the information > herein by anyone other than the intended recipient is prohibited. If you > have received this email by mistake, please notify us immediately by > telephone or e-mail.* > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Regards, Alessandro Parma == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Alessandro Parma DevOps Engineer GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
