Andrea Aime ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae9469ffc-5e16-4c2b-b7b0-b9c46e912f9e
 ) *created* an issue

GeoServer ( 
https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 ) / Bug ( 
https://osgeo-org.atlassian.net/browse/GEOS-9761?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 ) GEOS-9761 ( 
https://osgeo-org.atlassian.net/browse/GEOS-9761?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 ) Catalog points to resource objects, which in turn, point to a different 
catalog instance ( 
https://osgeo-org.atlassian.net/browse/GEOS-9761?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 )

Issue Type: Bug Assignee: Andrea Aime ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae9469ffc-5e16-4c2b-b7b0-b9c46e912f9e
 ) Components: Main Created: 07/Oct/20 12:32 PM Priority: Medium Reporter: 
Andrea Aime ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae9469ffc-5e16-4c2b-b7b0-b9c46e912f9e
 )

Looking at object references today, one can see the catalog pointing to a 
catalog facade, which in turn
refers to the actual CatalogInfo. Some of them, like StoreInfoImpl and 
ResourceInfoImpl, refer back to a catalog. However, it's not the same catalog 
pointing at them, but the temporary one created during the load process: the 
main catalog is fixed, referred by Spring, a secondary instance is created and 
loaded, and then the two are synched.

The issue was probably (re?-)introduced as a side effect of the isolated 
catalog work. The fast path for synch two DefaultCatalogFacade objects takes 
care of catalog references, but nowadays the syncTo gets a reference to an 
IsolatedCatalog instance, skipping the optimized copy path.
The non optimized copy path instead just loads objects, but fails to re-adjust 
the catalog references.

All in all this should not be causing leaks per se, but may well cause non 
obvious mis-behaviors in code that uses the resources's "getCatalog" method 
instead of relying of the one available in Spring.

( 
https://osgeo-org.atlassian.net/browse/GEOS-9761#add-comment?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 ) Add Comment ( 
https://osgeo-org.atlassian.net/browse/GEOS-9761#add-comment?atlOrigin=eyJpIjoiNDVlODQ2MDNiNjA1NDY5MmIxMmMxNWI4NTcxMmVlZWIiLCJwIjoiaiJ9
 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( 
https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail
 ) or iOS ( 
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8
 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100148- 
sha1:19001a3 )
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to