Hi Mark,
thanks! Had a look, looks like an improvement to me, the current settings
seem sensible.
The PR does not really contain the reformatted files, so to see the
difference one has to
check it out and run it locally. Mark, maybe you could put the result of
reformat in a separate commit,
so that if changes are needed, it's possible to wipe it and redo the
formatting? (and then force push).
It would help other devs get a quick "before and after" view.
One thing that I'm a bit hesitant about, is that empty lines are getting
removed. Sometimes these
lines are used to separate blocks, but the semantics of that is in our
head, don't think it's possible
to tell the plugin about it.
As another node, I'd suggest trying to run it on the applicationContext
files, they also are all over the place formatting wise.
Tried locally with the following modified config:
<includes>
<include>**/pom.xml</include>
<include>**/applicationContext.xml</include>
<include>**/applicationSecurityContext.xml</include>
</includes>
Love the result consistency, one thing that might not be too pleasing is
that namespace declarations
are now moved all in a single line, so:
<beans xmlns="http://www.springframework.org/schema/beans";
xmlns:batch="http://www.springframework.org/schema/batch";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-4.0.xsd
http://www.springframework.org/schema/batch
http://www.springframework.org/schema/batch/spring-batch-3.0.xsd";>
becomes:
<beans xmlns="http://www.springframework.org/schema/beans"; xmlns:batch="
http://www.springframework.org/schema/batch"; xmlns:xsi="
http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="
http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-4.0.xsd
http://www.springframework.org/schema/batch
http://www.springframework.org/schema/batch/spring-batch-3.0.xsd";>
When editing the file contents the difference is ignorable, but if one had
to add a namespace, it would be annoying.
Cheers
Andrea
On Mon, Jan 18, 2021 at 1:42 PM Mark Prins <[email protected]> wrote:
> hi all,
> I've opened a (draft) PR to format (and check formatting) of all pom
> files in the project: https://github.com/geoserver/geoserver/pull/4663
>
> It still needs some work, but some decisions should be made about things
> like indents etc...
>
> for now I've fixed the invalid xml and set up 4 spaces as indent, no
> tabs, lineendig as LF, use UTF-8 encoding, preserve whitespace in
> comments...
>
> This plugin will reformat the pom files as part of a regular maven build
> cycle, just like the fmt-maven-plugin does.
>
> Mark
>
>
> _______________________________________________
> Geoserver-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>
--
Regards, Andrea Aime
== GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf
Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa
(LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549
http://www.geo-solutions.it http://twitter.com/geosolutions_it
------------------------------------------------------- *Con riferimento
alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 -
Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni
circostanza inerente alla presente email (il suo contenuto, gli eventuali
allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i
destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per
errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le
sarei comunque grato se potesse darmene notizia. This email is intended
only for the person or entity to which it is addressed and may contain
information that is privileged, confidential or otherwise protected from
disclosure. We remind that - as provided by European Regulation 2016/679
“GDPR” - copying, dissemination or use of this e-mail or the information
herein by anyone other than the intended recipient is prohibited. If you
have received this email by mistake, please notify us immediately by
telephone or e-mail.*
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
