Gabriel Roldan ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A54db8b09-1e64-436a-adac-248049585cee
 ) *created* an issue

GeoServer ( 
https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 ) / Task ( 
https://osgeo-org.atlassian.net/browse/GEOS-10134?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 ) GEOS-10134 ( 
https://osgeo-org.atlassian.net/browse/GEOS-10134?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 ) Dead code: CatalogFactory.create(Class) ( 
https://osgeo-org.atlassian.net/browse/GEOS-10134?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 )

Issue Type: Task Affects Versions: 2.19.1 Assignee: Unassigned Components: Main 
Created: 06/Jul/21 1:24 AM Priority: Medium Reporter: Gabriel Roldan ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A54db8b09-1e64-436a-adac-248049585cee
 )

Stumbled upon this dead code in CatalogFactory / Impl. Should we just remove it?

CatalogFactory :

   /**
    * Extensible factory method.
    *
    * <p>This method should lookup the appropritae instance of {@link 
Extension} to create the
    * object. The lookup mechanism is specific to the runtime environement.
    *
    * @param clazz The class of object to create.
    * @return The new object.
    */
   <T extends Object> T create(Class<T> clazz);

   /** Factory extension. */
   interface Extension {

       /**
        * Determines if the extension can create objects of the specified class.
        *
        * @param clazz The class of object to create.
        */
       <T extends Object> boolean canCreate(Class<T> clazz);

       /**
        * Creates an instance of the specified class.
        *
        * <p>This method is only called if {@link #canCreate(Class)} returns 
<code>true</code>.
        *
        * @param clazz The class of object to create.
        * @param context A context to initialize the object.
        * @return The new object.
        */
       <T extends Object> T create(Class<T> clazz, Map<Object, Object> context);
   }

CatalogFactoryImpl :

   public <T extends Object> T create(Class<T> clazz) {
       return null;
   }

( 
https://osgeo-org.atlassian.net/browse/GEOS-10134#add-comment?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 ) Add Comment ( 
https://osgeo-org.atlassian.net/browse/GEOS-10134#add-comment?atlOrigin=eyJpIjoiMDU1ZjBjYWRlZTNiNGJiZGExZWNjY2U2ZTUyNTI2ZTkiLCJwIjoiaiJ9
 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( 
https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail
 ) or iOS ( 
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8
 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100168- 
sha1:f27f540 )
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to