That sounds like a very good plan then. Ian
On Mon, 4 Apr 2022 at 09:14, Andrea Aime <andrea.a...@geosolutionsgroup.com> wrote: > On Sat, Apr 2, 2022 at 10:22 AM Ian Turton <ijtur...@gmail.com> wrote: > >> I was going to ask if this included promoting the GeoTools kml module to >> supported but I see that it doesn't use it. >> > > The kml unsupported module is a datastore. While a PPIO can use such a > high level API, it has no need to. > To draw a couple of parallels: > > - GeoJSONPPIO uses low level GeoJSONWriter and GeoJSONReader (it could > be written against the stores, but it would be overkill, we just want to > read features out of a stream, and encode them onto a stream) > - ShapeZipPPIO uses a store, because it's not harder than using a > lower level API, we still need to dump on local filesystem first to zip > > > Is there a possibility to move the KML parsing and generating code back >> into GeoTools at some point in the future? >> > > The parsing is already using gt-xsd-kml just like the GeoTools KML > unsupported code. > The writing instead is using the GeoServer KML module, both for > consistency and functionality. That code might not be > that is easy to extract, as it was written with usage in GeoServer in mind > (depends in a lot of places on WMSMapContext/GetMapRequest). > > The gt-xsd-kml module has also encoding support, but as most XSD modules, > it's not symmetric (one has to write parsing and encoding > as separate groups of methods, ability to parse does not equate to the one > of writing, and vice versa). > I see the module has encoding tests, but don't know how well it works... I > recall Alessio had troubles making it work during the > first write of kmlppio, and eventually switched to the GeoServer kml > module instead. > > It's good to have consistent behavior between WFS and WPS output > formats... the other possibility would be to rewrite the > kml module to use gt-xsd-kml for encoding which... just gives me > nightmares TBH!!! > > Cheers > Andrea > > == > > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 333 8128928 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > -- Ian Turton
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
