I was going to use code style like we check for headers? Suggestions welcome. -- Jody Garnett
On Thu, 16 Jun 2022 at 12:52, Andrea Aime <andrea.a...@geosolutionsgroup.com> wrote: > Love to hear it's going to be progressive and pages based on old and new > can coexist. > Also like to see the QA checks to prevent further regressions! What tools > do you plan to use to run the tests? > I see PMD can be used to avoid inline styles > <https://pmd.github.io/latest/pmd_rules_html.html>, fits the bill, > although the overall list of rules is really small... Maybe you have > something better in mind? > > Cheers > Andrea > > > On Thu, Jun 16, 2022 at 11:04 AM Michel Gabriel <michel.gabr...@geocat.net> > wrote: > >> Hello Andrea, >> >> I will try to explain a bit what I want to do. >> >> - I will keep the UI the same as it is, I will replace hardcoded >> styles with proper classes that do the same. >> - No new styling will be introduced >> - The `geoserver.css` will stay, `bootstrap-utilities.css` will be >> added to provide extra styling possiblities for positioning purposes >> (padding, margin, left, right) >> - The `bootstrap-utilities.css` will not affect current styles, it >> only adds some extra classes you can use, if you don’t use them nothing >> will happen >> - When needed current styling (a combination of HTML/CSS) will be >> modified/modernised but the visual outcome will stay the same and if you >> don’t change HTML nothing will happen >> - We know it can be a lot of work, but when done correctly, it >> doesn’t have to be done all at once. We can target some improvements per >> PR >> (the first PR will add the bootstrap css file though so we can continue on >> top of that) >> - …and in all the years I’m doing this I learned to resist the >> temptation to add ‘unrelated things’ to just make things better :-) >> >> If you need more information or have any more questions, please ask. >> >> Kind regards, >> Michel Gabriël >> On 15 Jun 2022, 23:19 +0200, Jody Garnett <jody.garn...@gmail.com>, >> wrote: >> >> Michel will comment tomorrow, but yeah no interest in adding anything or >> changing visual appearance. Such an idea would happen after a cleanup like >> this makes it possible. >> >> If you are quite concerned about community modules the existing >> geoserver.css could stay in the mix for some year before being removed? >> Also for the community modules many of the html files everywhere are cut >> and pasted from other pages so I expect search and replace would be >> helpful. >> >> But really Michel is the css expert and indicates this is “easy” and >> would like to make the improvement (after working on customer themes for >> some years now and being well aware of the scope of the challenge). >> >> Jody >> >> On Wed, Jun 15, 2022 at 7:29 PM Andrea Aime < >> andrea.a...@geosolutionsgroup.com> wrote: >> >>> Hi Jody, >>> I've just skimmed through the proposal. >>> The idea of modernization and cleanup is nice, and needed. >>> The backwards compatibility breakage on custom CSS for the GeoServer UI >>> less so, but I think they are not used very much, not particularly worried >>> about it. >>> >>> What gets me really worried though is that this is not just a >>> geoserver.css change, but a wholesale change in all HTML files >>> to follow it: >>> >>> - I don't see any visual indication in the proposal, does it mean >>> the UI will look exactly the same? If not, do you already know what >>> you're >>> going to change? >>> - With just two developers, I don't see how you can go over all >>> extensions and community modules. If you simply intend to break all >>> community modules, you should say so, it should be a prominent message in >>> the proposal (they are not supported, but it does not mean they are not >>> used, PSC will have to agree to take on the upgrade work that will >>> follow, >>> as it happened for the REST config API sprint for example). A reasonable >>> approach would be to ensure old GUI modules do gracefully work even with >>> the new CSS, and would also help cover customizations/plugins outside of >>> the repository (plenty of them around). >>> - Even limiting yourself to core and extensions, are you going to >>> manually test before/after all the extension modules? Are you familiar >>> with >>> all of them? >>> - Going through the HTML files you'll have the temptation to just >>> add other unrelated changes to "make things better".. but these are not >>> really covered by the proposal. Can you resist the temptation? >>> >>> Cheers >>> Andrea >>> >>> >>> On Wed, Jun 15, 2022 at 3:25 PM Jody Garnett <jody.garn...@gmail.com> >>> wrote: >>> >>>> Jody and Michel here from the Bolsena code sprint with a proposal for >>>> cleaning up the use of css: >>>> >>>> https://github.com/geoserver/geoserver/wiki/GSIP-213 >>>> >>>> Scroll down to the bottom of the proposal for an example, feedback (and >>>> encouragement) welcome. >>>> -- >>>> Jody Garnett >>>> >>> _______________________________________________ >>>> Geoserver-devel mailing list >>>> Geoserver-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >>>> >>> >>> >>> -- >>> >>> Regards, >>> >>> Andrea Aime >>> >>> == >>> GeoServer Professional Services from the experts! >>> >>> Visit http://bit.ly/gs-services-us for more information. >>> == >>> >>> Ing. Andrea Aime >>> @geowolf >>> Technical Lead >>> >>> GeoSolutions Group >>> phone: +39 0584 962313 >>> >>> fax: +39 0584 1660272 >>> >>> mob: +39 333 8128928 >>> >>> https://www.geosolutionsgroup.com/ >>> >>> http://twitter.com/geosolutions_it >>> >>> ------------------------------------------------------- >>> >>> Con riferimento alla normativa sul trattamento dei dati personali (Reg. >>> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si >>> precisa che ogni circostanza inerente alla presente email (il suo >>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è >>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il >>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra >>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia. >>> >>> This email is intended only for the person or entity to which it is >>> addressed and may contain information that is privileged, confidential or >>> otherwise protected from disclosure. We remind that - as provided by >>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this >>> e-mail or the information herein by anyone other than the intended >>> recipient is prohibited. If you have received this email by mistake, please >>> notify us immediately by telephone or e-mail >>> >> -- >> -- >> Jody Garnett >> _______________________________________________ >> Geoserver-devel mailing list >> Geoserver-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geoserver-devel >> >> > > -- > > Regards, > > Andrea Aime > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 333 8128928 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail >
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
