Gabriel Roldan ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A54db8b09-1e64-436a-adac-248049585cee ) *created* an issue
GeoServer ( https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) / Improvement ( https://osgeo-org.atlassian.net/browse/GEOS-10560?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) GEOS-10560 ( https://osgeo-org.atlassian.net/browse/GEOS-10560?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) Make GeoServerConfigurationLock reentrant ( https://osgeo-org.atlassian.net/browse/GEOS-10560?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) Issue Type: Improvement Assignee: Gabriel Roldan ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A54db8b09-1e64-436a-adac-248049585cee ) Created: 24/Jun/22 11:12 PM Priority: Medium Reporter: Gabriel Roldan ( https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A54db8b09-1e64-436a-adac-248049585cee ) GeoServerConfigurationLock uses reentrant read/write locks internally but does not preserve that behavior. Since the lock can't know about the call chain that results in a lock request, it's important that reentrancy is preserved. A typical scenario is component A acquires a write lock to perform a bunch of operations through component B, which also acquires a write lock to perform more granular operations. Component B unlocks, and then component A unlocks. Currently, the ThreadLocal<LockType> is cleared on the first unlock, leaving open locks when the next call to GeoServerConfigurationLock.unlock() arrives. Also, if a write lock is already held, and a read lock is requested down the stream, the write lock shall be preserved. ( https://osgeo-org.atlassian.net/browse/GEOS-10560#add-comment?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) Add Comment ( https://osgeo-org.atlassian.net/browse/GEOS-10560#add-comment?atlOrigin=eyJpIjoiNWI2NzM0MjQwNjQ2NDEzNmE1MzRlMTBhMjBhM2JjNDQiLCJwIjoiaiJ9 ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:00501c8 )
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
