Think the 2.21.1 release bin download also fails to start?I

To fix should I download, add the correct start.jar and zip it back up?

On Wed, Aug 3, 2022 at 9:15 AM Andrea Aime <
andrea.a...@geosolutionsgroup.com> wrote:

> Noice, merged!
>
> Cheers
> Andrea
>
> On Wed, Aug 3, 2022 at 12:17 AM Jody Garnett <jody.garn...@gmail.com>
> wrote:
>
>> Here is a PR, works with local testing
>> https://github.com/geoserver/geoserver/pull/6087
>> --
>> Jody Garnett
>>
>>
>> On Tue, 2 Aug 2022 at 08:36, Jody Garnett <jody.garn...@gmail.com> wrote:
>>
>>> Checking
>>>
>>>
>>> 1) jetty-start-9.4.48.v20220622.jar is 154 KB
>>> 2) distribution start.jar is 164 KB
>>> MANIFEST.MF is identical )(same exported packages etc....)
>>>
>>> Diff folders:
>>> - org/eclipse/jetty/start/Modules.class
>>> - org/eclipse/jetty/start/StartArgs.class
>>> - org/eclipse/jetty/start/shaded (only in distribution)
>>> - org/eclipse/jetty/start/shaded/util/JavaVersion.class
>>> - org/eclipse/jetty/start/shaded/util/ManifestUtils.class
>>> - org/eclipse/jetty/start/shaded/util/TopologicalSort.class
>>>
>>> - org/eclipse/jetty/start/shaded/util/TopologicalSort$CyclicException.class
>>>
>>> - 
>>> org/eclipse/jetty/start/shaded/util/TopologicalSort$InitialOrderComparator.class
>>>
>>> Which is odd ...
>>>
>>> 3) What does distribution do?
>>>
>>>
>>> https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-distribution/pom.xml
>>> - uses ant run to do something
>>> - unpacks jetty-home
>>> - unpacks some wars
>>> - has an assembly
>>>
>>>
>>> https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-home/pom.xml
>>> - here it is a dependency on start using shade classifier
>>>
>>> dependencies:
>>>     <dependency>
>>>       <groupId>org.eclipse.jetty</groupId>
>>>       <artifactId>jetty-start</artifactId>
>>>       <version>${project.version}</version>
>>>       <classifier>shaded</classifier>
>>>     </dependency>
>>>
>>> maven-depeendency-plugin:
>>>
>>>                 <artifactItem>
>>>                   <groupId>org.eclipse.jetty</groupId>
>>>                   <artifactId>jetty-start</artifactId>
>>>                   <version>${project.version}</version>
>>>                   <classifier>shaded</classifier>
>>>                   <type>jar</type>
>>>                   <overWrite>true</overWrite>
>>>                   <includes>**</includes>
>>>
>>> <outputDirectory>${assembly-directory}</outputDirectory>
>>>                   <destFileName>start.jar</destFileName>
>>>                 </artifactItem>
>>>
>>> - so actually nothing special; just pulling a different classifier
>>>
>>>
>>> https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-start/pom.xml
>>> - okay it defines more than one classifier
>>>
>>>       <plugin>
>>>         <groupId>org.apache.maven.plugins</groupId>
>>>         <artifactId>maven-shade-plugin</artifactId>
>>>         <executions>
>>>           <execution>
>>>             <phase>package</phase>
>>>             <goals>
>>>               <goal>shade</goal>
>>>             </goals>
>>>             <configuration>
>>>
>>> <createDependencyReducedPom>false</createDependencyReducedPom>
>>>               <createSourcesJar>true</createSourcesJar>
>>>               <shadedArtifactAttached>true</shadedArtifactAttached>
>>>               <shadedClassifierName>shaded</shadedClassifierName>
>>>
>>> So yeah, try pulling the same dependency as distribution:
>>>
>>>     <dependency>
>>>       <groupId>org.eclipse.jetty</groupId>
>>>       <artifactId>jetty-start</artifactId>
>>>       <version>${project.version}</version>
>>>       <classifier>shaded</classifier>
>>>     </dependency>
>>>
>>>
>>>
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Tue, 2 Aug 2022 at 07:57, Andrea Aime <
>>> andrea.a...@geosolutionsgroup.com> wrote:
>>>
>>>> Hmm... unsure.
>>>>
>>>> I did try with this one:
>>>>
>>>> https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-start/9.4.48.v20220622
>>>>
>>>> But the jar downloaded from that link does not work, Jetty won't start.
>>>> What worked for me, was to grab the binary distribution, also available
>>>> from maven repos, and then grabbing start.jar from it:
>>>>
>>>> https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-distribution/9.4.48.v20220622
>>>>
>>>> and in particular this file:
>>>>
>>>> https://repo1.maven.org/maven2/org/eclipse/jetty/jetty-distribution/9.4.48.v20220622/jetty-distribution-9.4.48.v20220622.zip
>>>>
>>>> Unzip it, you'll get a working start.jar.
>>>>
>>>> Cheers
>>>> Andrea
>>>>
>>>> On Tue, Aug 2, 2022 at 4:43 PM Jody Garnett <jody.garn...@gmail.com>
>>>> wrote:
>>>>
>>>>> Is there a maven dependency for that jar?
>>>>> --
>>>>> Jody Garnett
>>>>>
>>>>>
>>>>> On Mon, 1 Aug 2022 at 10:47, Andrea Aime <
>>>>> andrea.a...@geosolutionsgroup.com> wrote:
>>>>>
>>>>>> Trying to start a nightly I get:
>>>>>>
>>>>>> ERROR : Nothing to start, exiting ...
>>>>>>
>>>>>> It seems the usual issue, start.jar has not been updated along with
>>>>>> the
>>>>>> latest Jetty version upgrade.
>>>>>>
>>>>>> We'd really need to either automate fetching that jar, and/or adding
>>>>>> tests
>>>>>> to make sure the bin package is working properly (if that is done, it
>>>>>> could open the interesting
>>>>>> possibility of also trying the start-up with each and every extension
>>>>>> module, too).
>>>>>>
>>>>>> In the meantime, this seems to do the trick:
>>>>>> https://github.com/geoserver/geoserver/pull/6083
>>>>>>
>>>>>> Cheers
>>>>>> Andrea
>>>>>>
>>>>>> ==
>>>>>> GeoServer Professional Services from the experts!
>>>>>>
>>>>>> Visit http://bit.ly/gs-services-us for more information.
>>>>>> ==
>>>>>>
>>>>>> Ing. Andrea Aime
>>>>>> @geowolf
>>>>>> Technical Lead
>>>>>>
>>>>>> GeoSolutions Group
>>>>>> phone: +39 0584 962313
>>>>>>
>>>>>> fax:     +39 0584 1660272
>>>>>>
>>>>>> mob:   +39  339 8844549
>>>>>>
>>>>>> https://www.geosolutionsgroup.com/
>>>>>>
>>>>>> http://twitter.com/geosolutions_it
>>>>>>
>>>>>> -------------------------------------------------------
>>>>>>
>>>>>> Con riferimento alla normativa sul trattamento dei dati personali
>>>>>> (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati 
>>>>>> “GDPR”),
>>>>>> si precisa che ogni circostanza inerente alla presente email (il suo
>>>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>>>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>>>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>>>>>> operazione è illecita. Le sarei comunque grato se potesse darmene 
>>>>>> notizia.
>>>>>>
>>>>>> This email is intended only for the person or entity to which it is
>>>>>> addressed and may contain information that is privileged, confidential or
>>>>>> otherwise protected from disclosure. We remind that - as provided by
>>>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of 
>>>>>> this
>>>>>> e-mail or the information herein by anyone other than the intended
>>>>>> recipient is prohibited. If you have received this email by mistake, 
>>>>>> please
>>>>>> notify us immediately by telephone or e-mail
>>>>>> _______________________________________________
>>>>>> Geoserver-devel mailing list
>>>>>> Geoserver-devel@lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>>>
>>>>>
>>>>
>>>> --
>>>>
>>>> Regards,
>>>>
>>>> Andrea Aime
>>>>
>>>> ==
>>>> GeoServer Professional Services from the experts!
>>>>
>>>> Visit http://bit.ly/gs-services-us for more information.
>>>> ==
>>>>
>>>> Ing. Andrea Aime
>>>> @geowolf
>>>> Technical Lead
>>>>
>>>> GeoSolutions Group
>>>> phone: +39 0584 962313
>>>>
>>>> fax:     +39 0584 1660272
>>>>
>>>> mob:   +39  339 8844549
>>>>
>>>> https://www.geosolutionsgroup.com/
>>>>
>>>> http://twitter.com/geosolutions_it
>>>>
>>>> -------------------------------------------------------
>>>>
>>>> Con riferimento alla normativa sul trattamento dei dati personali (Reg.
>>>> UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
>>>> precisa che ogni circostanza inerente alla presente email (il suo
>>>> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
>>>> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
>>>> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
>>>> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>>>>
>>>> This email is intended only for the person or entity to which it is
>>>> addressed and may contain information that is privileged, confidential or
>>>> otherwise protected from disclosure. We remind that - as provided by
>>>> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
>>>> e-mail or the information herein by anyone other than the intended
>>>> recipient is prohibited. If you have received this email by mistake, please
>>>> notify us immediately by telephone or e-mail
>>>>
>>>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts!
>
> Visit http://bit.ly/gs-services-us for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions Group
> phone: +39 0584 962313
>
> fax:     +39 0584 1660272
>
> mob:   +39  339 8844549
>
> https://www.geosolutionsgroup.com/
>
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
> Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE
> 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si
> precisa che ogni circostanza inerente alla presente email (il suo
> contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è
> riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il
> messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra
> operazione è illecita. Le sarei comunque grato se potesse darmene notizia.
>
> This email is intended only for the person or entity to which it is
> addressed and may contain information that is privileged, confidential or
> otherwise protected from disclosure. We remind that - as provided by
> European Regulation 2016/679 “GDPR” - copying, dissemination or use of this
> e-mail or the information herein by anyone other than the intended
> recipient is prohibited. If you have received this email by mistake, please
> notify us immediately by telephone or e-mail
>
-- 
--
Jody Garnett
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to