Comments inline: On Thu, 3 Nov 2022 at 00:16, Carsten Klein <c.kl...@datagis.com> wrote:
> Hello there, > > now the 2nd optimization of the new SpatialJSON format (Shared String > Table) is merged into main. Many thanks for that :-) > Must be this one https://github.com/geoserver/geoserver/pull/6320 > I have prepared two more single-commit PRs for porting back everything > to 2.22.x and 2.21.x. Before pushing these into my forked repo and > issuing the PRs, I'd like to ask how to do this correctly concerning > Jira tickets and, what Andrea mentioned recently, GeoServer's "Jira > ticket first" approach. > Since Jira tickets are required for adding stuff to the change log, I > guess having two tickets for these PRs is a good idea. After creating > the Jira ticket, I know its ticket number (e. g. GEOS-12345). How do I > link the the ticket with the PR? Is it just naming the PR [GEOS-12345] > ... whatever? Is it crucial to name the commit behind the PR > accordingly? What's technically required and what is best practice? > As recommended by Andrea I've issued a Jira ticket (GEOS-10708) for the > first PR of the new community module. However, it's still unassigned and > open. Will this ever be used for the change log? Get tickets "linked" to > a PR closed automatically? > Cleaning up: 1. Changed your PR title to: [GEOS-10708] SpatialJSON Shared String Table Feature 2. If the title has the pattern [GEOS-xxxx] when created a bot provides a link to the jira ticket, I added this by hand editing PR description 3. Added a link to the PR in the Jira ticket; using add web link 4. I added the backport labels for the backport bot to see, ... and it failed to backport as the community modules is not backported yet. > > Sorry for asking all that but, it's a quite complex system and new to me > (I'm doing this for the first time). I want to do it the right way now > and as well for future contributions, but still feel kind of lost... :-p > Thanks for asking for help; it got a little complicated to clean up ., > > Cheers > Carsten > > > -- > > Carsten Klein > Lead Software Engineer > > DataGis GmbH > > Johann-Strauß-Str. 26 > 70794 Filderstadt > GERMANY > > Phone: +49 7158 9490 106 > Fax: +49 7158 9490 111 > > E-Mail: c.kl...@datagis.com > Internet: www.datagis.com > > Commercial Register: Stuttgart, HRB 225945 > Management: Dr. Gunter Hahn, Markus Ruess, Carsten Klein > > > > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel >
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
