Jody Garnett (
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3
) *created* an issue
GeoServer (
https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
) / Improvement (
https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
) GEOS-10740 (
https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
) Service enabled does not respect minimal/custom service names (
https://osgeo-org.atlassian.net/browse/GEOS-10740?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
)
Issue Type: Improvement Affects Versions: 2.22-RC Assignee: Unassigned
Components: Main, Security Created: 09/Nov/22 6:32 AM Priority: Medium
Reporter: Jody Garnett (
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae422bb7f-4808-47e3-837f-13db0e6681e3
)
Follow on to https://osgeo-org.atlassian.net/browse/GEOS-10702 (
https://osgeo-org.atlassian.net/browse/GEOS-10702 ) ; the same problem is found
in other code that assumes service.getName() is a useful value.
The root cause is the file contents being structured like:
<wms>
<id>wms</id>
<enabled>true</enabled>
<name>GeoServer WMS</name>
<title>GeoServer Web Map Service</title>
And code trying to check using *info.getName()* rather than *info.getId()* , as
we learned apparently *info.getId()* is not especially safe either.
*ServiceDescriptionProvider.isAvailable()* is checking
*ServiceResourceProvider.getServicesForResource(layer)* and needs constant it
can trust to check against.
a) On review *getServicesForResource(layer)* checks if the ResourceInfo is
compatible with the service and does not check if the service is enabled for
the layer.
b) Checking *ResourceInfo.getDisabledServices()* list; and it is called by
*DisabledServiceResourceFilter* (which also provides an system property
*org.geoserver.service.disabled* used disable services externally)
(
https://osgeo-org.atlassian.net/browse/GEOS-10740#add-comment?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
) Add Comment (
https://osgeo-org.atlassian.net/browse/GEOS-10740#add-comment?atlOrigin=eyJpIjoiNzRhYzM3NmI2ODE1NDk0OGI2MGQxY2Y0ZmQ1OTRjYzciLCJwIjoiaiJ9
)
Get Jira notifications on your phone! Download the Jira Cloud app for Android (
https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail
) or iOS (
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8
) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210-
sha1:ffe1a02 )
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
