Hi Joseph, thanks for sharing the progress. Some additions inline below On Tue, Jan 17, 2023 at 10:31 PM Joseph Miller <millerjos...@gmail.com> wrote:
> *Spring MVC Content Negotiation* > ContentNegotiationConfigurer.favorPathExtension is deprecated (and no > longer the default configuration) because Spring wants to discourage > extensions in paths. Removing extensions would cause GeoServer REST API > backwards compatibility issues that will have to be addressed in the > future. For now, we are suppressing the deprecation warning and turning on > this configuration option. > Some references about content negotiation and the deprecation itself, for reference: - Docs about suffix match <https://docs.spring.io/spring-framework/docs/current/reference/html/web.html#mvc-ann-requestmapping-suffix-pattern-match> - The issue that deprecated path extensions <https://github.com/spring-projects/spring-framework/issues/24179> This issue affects the REST API, which uses a suffix match to decide about the response content. The OGC API module is currently not using such a convention, so it's not affected. Speaking of OGC APIs, we made it pass all tests and QA before the Spring upgrade, and it's still building with no test nor QA failures after the upgrade. In addition to that, we're looking into the OAuth modules, which may be affected by the upgrades as well. Here we applied the same treatment as OGC API, but disabled the deprecation checks, making those modules pass a full build with the following command: mvn clean install -Dqa -nsu -Poauth2-all -Dlint=unchecked -T6 They have been recently broken again by the CSS overhaul, but the fix is easy, and then the modules do build. However, automated tests are far from covering the full functionality, so we are looking into doing manual testing as well before the RC. I have already reviewed the changes in both PRs before they were posted to the main repo so... anyone else wants to have a look? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
