No, there were no changes to GWC since 1.21.3 so we decided not to make a
new build of GWC

Ian

On Mon, 30 Jan 2023 at 14:55, Jody Garnett <jody.garn...@gmail.com> wrote:

> Checking https://github.com/geoserver/geoserver/blob/2.22.1/src/pom.xml
>
> It has <gwc.version>1.21.3</gwc.version>
>
> Should this be 1.22.0
> <https://github.com/GeoWebCache/geowebcache/blob/1.22.0/geowebcache/pom.xml>
>  ?
> --
> Jody Garnett
>
>
> On Fri, Jan 27, 2023 at 1:14 PM Ian Turton <ijtur...@gmail.com> wrote:
>
>> My fault, I knew I shouldn't mess with the settings with out reading the
>> source code :-(
>>
>> I'll run it again.
>>
>> Ian
>>
>> On Fri, 27 Jan 2023 at 12:11, Jody Garnett <jody.garn...@gmail.com>
>> wrote:
>>
>>> I am glad we have an answer.
>>> Personally I understood those parameters only did a build when a
>>> revision was supplied; if an actual release tag is used no building is
>>> required?
>>>
>>> I understand that these were used to issue an emergency hotfix in the
>>> past. Now we tend to just make another geotools release if a critical fix
>>> is required.
>>>
>>> Perhaps these options could be removed?
>>> --
>>> Jody Garnett
>>>
>>>
>>> On Fri, Jan 27, 2023 at 12:32 PM Andrea Aime <
>>> andrea.a...@geosolutionsgroup.com> wrote:
>>>
>>>> Hi, I've spent some time investigating what happened, I believe it's
>>>> user error caused by confusing parameters and a bug in the release 
>>>> script...
>>>> The build has these two parameters, that I normally don't touch, set to
>>>> "skip":
>>>>
>>>> [image: image.png]
>>>> I normally don't touch them due to lack of understanding, but the
>>>> description seems to suggest "skip GT build", which is indeed
>>>> something we don't need during a release, the upstream builds are done
>>>> already.
>>>> But looking at how they work in build_release.sh
>>>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L156>,
>>>> they skip the build but also skip setting gt_tag and gwc_tag,
>>>> which then are used to update the version numbers in the pom files
>>>> <https://github.com/geoserver/geoserver/blob/main/build/build_release.sh#L199>
>>>> .
>>>>
>>>> Seems like a bug in the logic of the release script IMHO, but for now,
>>>> better not set those to "skip" and let them do the extra,
>>>> unnecessary builds.
>>>>
>>>> Cheers
>>>> Andrea
>>>>
>>>> _______________________________________________
>>>> Geoserver-devel mailing list
>>>> Geoserver-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> Geoserver-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>
>>
>>
>> --
>> Ian Turton
>>
>

-- 
Ian Turton
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to