Niels Charlier ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf
 ) *created* an issue

GeoServer ( 
https://osgeo-org.atlassian.net/browse/GEOS?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 ) / Improvement ( 
https://osgeo-org.atlassian.net/browse/GEOS-10858?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 ) GEOS-10858 ( 
https://osgeo-org.atlassian.net/browse/GEOS-10858?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 ) jdbc-config turns off isolated workspace support ( 
https://osgeo-org.atlassian.net/browse/GEOS-10858?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 )

Issue Type: Improvement Assignee: Niels Charlier ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf
 ) Created: 10/Feb/23 10:13 AM Priority: Medium Reporter: Niels Charlier ( 
https://osgeo-org.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1d2c4019-de4e-4624-8b27-2486941601cf
 )

Currently, the default catalog wraps a ‘IsolatedWorkspaceCatalogFacade’ around 
the default catalog facade to support isolated workspaces. But it only does so 
in the constructor. The ‘setCatalogFacade’ will overwrite it, which is 
currently used by jdbcconfig.

The problem could be resolved at the jdbcconfig side, however I see several 
arguments to move the addition of the wrapper from the constructor to the 
setter method:

* currently, jdbcconfig is the only module in the official code base (including 
community modules) that replaces the catalog facade.
* even if people use the API in other projects, I can see no situation where 
one would want to turn off the isolated workspace facade. It is a wrapper that 
adds core functionality but doesn’t depend in any way on any particular 
implementation of the catalog facade, it is compatible with any other custom 
catalog facade.

Alternatively, an alternative setter method could be added to the API so people 
can still overwrite the isolated workspace facade if they wanted to (but I 
cannot see any reason why)

( 
https://osgeo-org.atlassian.net/browse/GEOS-10858#add-comment?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 ) Add Comment ( 
https://osgeo-org.atlassian.net/browse/GEOS-10858#add-comment?atlOrigin=eyJpIjoiN2FkNTA2MGJkZTQxNGVjYjgzYzU4Y2JiYzM2MTgwYWQiLCJwIjoiaiJ9
 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( 
https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail
 ) or iOS ( 
https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8
 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100215- 
sha1:a0f3b6a )
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to