There was a good discussion in today's meeting and I have an action item to take my feedback to the email list.
But first of all +1 this is an excellent addition to the codebase, and a good way to gradually introduce more safety measures to the project with small attainable goals. And now for the feedback ... regex is not an appropriate default for this addition as it is an *expert only* concept for something that needs to be easy for the default case. The default case being limiting access to a URL prefix. Ideas proposed: - Writing an example of how to perform the common case in the documentation? I do not think this will be "good enough" as the functionality is too important to trust that documentation will be in reach. - Adding an example to a "?" hint may be a bit better; but once again this is too important to trust to docs - Making the disk format have a "type" with a default of regex allows the topic to be pushed off until later (sigh) - Adding a regex tester to the application alongside the input control is ... probably effective but still places this feature at "expert only" level Some ideas I would find okay: 1) Adding the default for regex type: The field default prompt:*^http://localhost:8080/geoserver/ows\?(.*)$ <http://localhost:8080/geoserver/ows\?(.*)$> * This would be easy to understand and adapt for users. 2) Making a "prefix" type that assumes *^ *and *.*$* The field default prompt: *http://localhost:8080/geoserver/ows <http://localhost:8080/geoserver/ows>?* This would cover the common case with an easy to understand interaction, and regex could be available for expert users. -- Jody Garnett On Wed, Mar 22, 2023 at 9:15 AM Andrea Aime < andrea.a...@geosolutionsgroup.com> wrote: > HI all, > this is a revival of the old GSIP-189, a bit modernized, with a smaller > initial scope (that should help us get an implementation going safeguarding > some remote access functionality sooner rather than later). > > Please review, discuss, vote: > https://github.com/geoserver/geoserver/wiki/GSIP-218 > > Best regards > Andrea > > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > _______________________________________________ > GeoTools-Devel mailing list > geotools-de...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel >
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
