On Fri, 1 Sept 2023 at 14:57, Andrea Aime <andrea.a...@geosolutionsgroup.com> wrote:
> Hi all, > today I was trying to make a build and found the following failure: > > ------------------------------------------------------------------------------- > Test set: org.geoserver.wfs.response.CSVOutputFormatTest > ------------------------------------------------------------------------------- > Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.464 s <<< > FAILURE! - in org.geoserver.wfs.response.CSVOutputFormatTest > testDates(org.geoserver.wfs.response.CSVOutputFormatTest) Time elapsed: > 0.019 s <<< FAILURE! > org.junit.ComparisonFailure: expected:<[Sun, Ja]n 1, '17> but was:<[dom, ge]n > 1, '17> > at > org.geoserver.wfs.response.CSVOutputFormatTest.assertDates(CSVOutputFormatTest.java:546) > at > org.geoserver.wfs.response.CSVOutputFormatTest.testDates(CSVOutputFormatTest.java:526) > > > It's due to a recent test that checks date formatting, without ensuring > the expected locale is set. > Now I'm wondering, should we have an extra build among the Github actions, > that sets the system locale and maybe even the timezone to something > "different", so that cases like this one would be found out before PR merge? > > Suggestions for the locale, timezone, and other possible settings to rock > the boat a little bit? > I'd suggest a GMT+ and a GMT- zone for timezone testing, just based on previous issues we've had. As for locales I'd guess anything non-english should be a good test plus may be one with a non-ascii font like Korean, Japanese or Arabic? Ian > > Cheers > Andrea > > > == > GeoServer Professional Services from the experts! > > Visit http://bit.ly/gs-services-us for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions Group > phone: +39 0584 962313 > > fax: +39 0584 1660272 > > mob: +39 339 8844549 > > https://www.geosolutionsgroup.com/ > > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE > 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si > precisa che ogni circostanza inerente alla presente email (il suo > contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è > riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il > messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra > operazione è illecita. Le sarei comunque grato se potesse darmene notizia. > > This email is intended only for the person or entity to which it is > addressed and may contain information that is privileged, confidential or > otherwise protected from disclosure. We remind that - as provided by > European Regulation 2016/679 “GDPR” - copying, dissemination or use of this > e-mail or the information herein by anyone other than the intended > recipient is prohibited. If you have received this email by mistake, please > notify us immediately by telephone or e-mail > _______________________________________________ > Geoserver-devel mailing list > Geoserver-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- Ian Turton
_______________________________________________ Geoserver-devel mailing list Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
