Hello Andrea and others,
I noticed today that on newer versions of geoserver no wicket tests are
running any more, and found this email from last year. Are there any
plans to run wicket tests again?
Related to this issue is that all the web tests of taskmanager community
modules are broken. After figuring out the problem is with the
WicketTester, I wanted to see how other wicket tests are not failing.
Then I found out the reason is that they are not running any more at all.
Regards
Niels
On 10/8/24 15:00, Andrea Aime wrote:
Hì all,
Daniele just reported me some mysterious issues with the MapML module:
the build was running no tests at all, just passing without executing
a single one.
We looked into it, and all modules where the new junit-jupiter (JUnit
5) dependency has been added, fail to run the JUnit 4 tests. The
dependency has been added as part of the Wicket 9 upgrade merge, as
the new Wicket testing framework needs the JUnit 5 classes in the
classpath.
The issue is that surefire picks the JUnit runner based on what's in
the classpath, if it finds JUnit5, it will only run JUnit5 tests.
Now... I could understand if this affected a few modules that are
mixing in wicket dependencies, but even web-core builds with the
following:
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
One way to have the Junit 4 tests to run, is to have the junit-vintage
engine installed, which is still part of JUnit5, but able to run
JUnit4 tests. I've tried on web-cor, and the result looks grim... once
the tests start running, there's quite a bit of failures:
[ERROR] Failures:
[ERROR] LayerGroupEditPageTest.testLayerGroupLinkWithWorkspace:299
path:
'publishedinfo:tabs:panel:layers:popup:content:listContainer:items'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testLayerGroupStyle:722 path:
'publishedinfo:tabs:panel:layerGroupStyles:listContainer:styleList:0:layerGroupStylePanel:layerGroupEntryPanel:popup:content:listContainer:items:1:itemProperties:0:component:link'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testLayerGroupStyle2:775 path:
'publishedinfo:tabs:panel:layerGroupStyles:listContainer:styleList:0:layerGroupStylePanel:layerGroupEntryPanel:popup:content:listContainer:items:3:itemProperties:0:component:link'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testLayerGroupStyleSelection:862 path:
'publishedinfo:tabs:panel:layerGroupStyles:listContainer:styleList:0:layerGroupStylePanel:layerGroupEntryPanel:popup:content:listContainer:items:2:itemProperties:0:component:link'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testLayerLink:212 path:
'publishedinfo:tabs:panel:layers:popup:content:listContainer:items'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testLayerLinkWithWorkspace:265 path:
'publishedinfo:tabs:panel:layers:popup:content:listContainer:items'
does not exist for page: LayerGroupEditPage
[ERROR] LayerGroupEditPageTest.testStyleGroupLink:238 path:
'publishedinfo:tabs:panel:layers:popup:content:listContainer:items'
does not exist for page: LayerGroupEditPage
[ERROR] ResourceConfigurationPageTest.testConsistentUpdateWMTSBbox:834
path:
'publishedinfo:tabs:panel:theList:0:content:referencingForm:nativeSRS:popup:content:table:listContainer:items:1:itemProperties:0:component:link'
does not exist for page: ResourceConfigurationPage
[ERROR] ResourceConfigurationPageTest.testWFSDataStoreResource:467
path:
'publishedinfo:tabs:panel:theList:0:content:referencingForm:nativeSRS:popup:content:table:listContainer:items:1:itemProperties:0:component:link'
does not exist for page: ResourceConfigurationPage
[ERROR] ResourceConfigurationPageTest.testWMTSOtherCRS:584 path:
'publishedinfo:tabs:panel:theList:0:content:referencingForm:nativeSRS:popup:content:table:listContainer:items:1:itemProperties:0:component:link'
does not exist for page: ResourceConfigurationPage
[ERROR] ResourceConfigurationPageTest.testWMTSOtherCRSUrnFormat:622
path:
'publishedinfo:tabs:panel:theList:0:content:referencingForm:nativeSRS:popup:content:table:listContainer:items'
does not exist for page: ResourceConfigurationPage
[ERROR] CRSPanelTest.testPlanetaryList:245 Unable to set value.
Couldn't find component with name:
crs:popup:content:table:filterForm:filter ==> expected: not <null>
[ERROR] CRSPanelTest.testPlanetaryPopupWindow:227 path:
'form:crs:popup:content:wkt' does not exist for page: CRSPanelTestPage
[ERROR] CRSPanelTest.testPopupWindow:69 path:
'form:crs:popup:content:wkt' does not exist for page: CRSPanelTestPage
[ERROR] Errors:
[ERROR] GeoServerAboutPageTest.testHideSensitiveInfo:40 »
WicketRuntime The component(...
[ERROR] GeoServerAboutPageTest.testLoginFormAction:21 » WicketRuntime
The component(s)...
[INFO]
[ERROR] Tests run: 405, Failures: 14, Errors: 2, Skipped: 10
[INFO]
This is just web-core... how many more are broken?
I think the Wicket 9 merge should be reverted until it actually
builds. Opinions?
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts!
Visit http://bit.ly/gs-services-us <http://bit.ly/gs-services-us>for
more information.
==Ing. Andrea Aime @geowolfTechnical Lead
GeoSolutions Groupphone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
https://www.geosolutionsgroup.com/ <https://www.geosolutionsgroup.com/>
http://twitter.com/geosolutions_it <http://twitter.com/geosolutions_it>
-------------------------------------------------------
Con riferimento alla normativa sul trattamento dei dati personali
(Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati
“GDPR”), si precisa che ogni circostanza inerente alla presente email
(il suo contenuto, gli eventuali allegati, etc.) è un dato la cui
conoscenza è riservata al/i solo/i destinatario/i indicati dallo
scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a
cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato
se potesse darmene notizia.This email is intended only for the person
or entity to which it is addressed and may contain information that is
privileged, confidential or otherwise protected from disclosure. We
remind that - as provided by European Regulation 2016/679 “GDPR” -
copying, dissemination or use of this e-mail or the information herein
by anyone other than the intended recipient is prohibited. If you have
received this email by mistake, please notify us immediately by
telephone or e-mail
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
