On Sat, Feb 23, 2013 at 4:48 PM, Christian Mueller <
[email protected]> wrote:
> Interesting, looking at the code in GeoServerSecurityManager I found the
> following snippet
>
> /*
> * list of file watchers
> * TODO: we should probably manage these better rather than just
> throwing them in a
> * list, repeated loads will cause this list to fill up with
> threads
> */
> protected List<FileWatcher> fileWatchers = new
> ArrayList<FileWatcher>();
>
>
> I think it would be better to register the watchers in a Map using the
> canonical file name as a key. Upon reload, an existing watcher should be
> terminated.
>
Right, except that "reload" does not actually go through that code. It
seems it's triggered only by a application context event of spring context
reload,
which at runtime should never happen.
>
> Andrea, I have no idea why you have always 2 threads but looking on the
> Java code, this issue should be fixed.
>
Right, but before fixing it, it would be also know what's causing it.
If we lack understanding of how things work, we might just end up making a
change that introduces another bug.
>
> Should I open a JIRA issue
>
I think you should.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users
