Hi,
in the current code base we have three properties that LayerInfoImpl tries
to keep in synch between
the layer and the resource:
- name
- enabled
- advertised
Having them in synch is pretty important, as LayerInfo is used only by WMS,
whilst WFS and WCS
use the underlying resource.
Also, the AdvertisedCatalog (which used to be a filter in previous
releases) use the advertised
flag of the resources to decide whether to return them.
Unfortunately it seems that any attempt to edit enabled and advertised will
result in the data stored
on disk to get inconsistent, with the layer.xml containing what we edited
on the GUI, but the
resource xml file (featuretype.xml, wmsLayer.xml, coverage.xml) will have a
enabled and advertised
flags that almost seem random, but are never consistent with the layer ones.
Debugged the issue, and tracked down the problem to how we save stuff:
- the resource get saved, and stored on disk
- the layer gets saved on disk, then the modification proxy does the
commit,
LayerInfoImpl tries to synch the resource, but it's too late
Tried to invert the way things are saved, first layer then resource, but
that does not change a thing,
since the layer has a direct reference to ResourceInfo (no modification
proxy),
while the save subsystem looks at the properties modified via a
ModificationProxy.
Then I looked at why name is always in synch instead.. and saw it's because:
- the name is edited directly against the resource
- the layer does not have a name attribute, it just reflects the resource
one
Well, I guess we could do the same for enabled and advertised....
This is an old bug (at least for the enabled property, it dates back to the
layer/resource split),
but it basically make enabled/advertised unusable, so I'd like to fix it in
2.3.x before releasing it.
I'll come up with a patch shortly, can someone follow up and review?
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users
