I do most of my development on OSX but was getting a variety of different errors running the tests so I switched to Ubuntu 12.04. After installing perceptualdiff in Ubuntu, the test failure below was the only one (in the render module).
Thanks, Michael On Apr 3, 2014, at 10:19 AM, Andrea Aime <[email protected]> wrote: > On Tue, Apr 1, 2014 at 12:22 AM, Michael Romero <[email protected]> > wrote: > Thanks Andrea. I fixed the bug and created a pull request > (https://github.com/geotools/geotools/pull/407). However, there are two > potential issues: > > 1.) I don't have a signed contribution license. It's only 4 lines of code > so this may not be necessary. > > 2.) I didn't include a unit test. I'm having trouble getting the tests to > pass on master, even before my changes. I'm getting an > ArrayIndexOutOfBoundsException from line 173 of SLDStyleFactoryTest.java. > The variable coordsExpected (and coords) is a double array of size 2 and the > Javadocs for the currentSegment method (line 173) says it needs an array size > 6, hence the exception. If I change the initialization to create an array of > size 6 the test passes. I'm not sure how this test is passing for other > developers and on the CI server. I tried Java 6 & 7. > > > Thanks for the patch. For 4 lines indeed the contributor agreement is not > required, but a test will be, I'll see if I can write on in spare time. > Which OS are you on? OSX? I hear the are problems running rendering tests on > that platform as the Apple JVM comes with some > native libs that are OSX specific. > > Cheers > Andrea > > -- > == > Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK > for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > -------------------------------------------------------
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------
_______________________________________________ Geoserver-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-users
