On 9/19/05, Matthias Basler <[EMAIL PROTECTED]> wrote: > Zitat von [EMAIL PROTECTED]: > > > Go ahead and make those changes (in 2.1.x and trunk). > > I remind you that I am not authorized to commit to GeoTools, only Spike. I'd > like to stick with that. So I need someone to actually review the code for > bugs > and merge/commit the changes. > > P.S. Some days after I sent the edited classes I found that my StreamingRender > had duplicate checks. (I.e. it checked some arguments twice, unnecessarily.) I > corrected this later. > > > Please make sure you update the example at the top of Renderer.java (the > > interface)... > > I can have a look. Don't think something changed there. > > I will attach the three classes to a JIRA task when I have done so. > > > James wanted to replace the "old" Renderer with this (new) one and > > delete Renderer2D. Just to be clear I was talking about Renderer and not Renderer2D.
> > Not sure what the implication of this are, though. > > Hm... not sure deleting/replacing the old "Renderer" interface is nice for the > GT users. Was it deprecated before? I don't think so. > I personally would not have a problem with this, though. Not deprecated, no, but I would point to the following JavaDoc lines: * Base interface for renderer. This is very much work in progress. * <strong>Note: this interface will changes in future versions.</strong> That said, if someone can come up with a new name that will reduce rather than increase the potential for confusion then I be happy to go with doing something else. James ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Geotools-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/geotools-devel
