Review and commit changes on StreamingRenderer, Renderer and ~Utilities
-----------------------------------------------------------------------
Key: GEOT-689
URL: http://jira.codehaus.org/browse/GEOT-689
Project: GeoTools
Type: Task
Components: renderer
Versions: 2.2.M0
Reporter: Matthias Basler
Assigned to: Martin Desruisseaux
Priority: Minor
Fix For: 2.2.M1
Attachments: StreamingRenderer_and_Co2.zip
I' ve attached the three mentioned files.
I used files from trunk 1-2 weeks ago and perfomed following changes:
- Added third paint call, in case both envelope and transform are already known
(were f.e. calculated by some ViewportModel class)
public void paint( Graphics2D graphics, Rectangle paintArea,
Envelope envelope, AffineTransform worldToScreen)
- Both other paint calls call this one internally. This avoids duplicate
viewport object calculations: Befor the envelope was calculated from the
transform and later the transform was calculated from the envelope again.
- separated out all viewport related calculations to RendererUtilities, i.e.
added method
public static Envelope createMapEnvelope(Rectangle paintArea, AffineTransform
worldToScreen)
P.S.: I also changed the "Renderer"'s usage example (in the JavaDoc). There
should never be the need to call the RendererUtil's methods by the API user.
They are called within the StreamingRenderer's paint methods, and potentially
by other Renderer implementations.
---------
Things to do:
- Check for possibly introduced bugs.
- Please review how missing arguments are handled: Which arguments are checked
when. What happens if an argument is null? Currently this quits with an "info"
message, as was the case in LiteRenderer.
- Merge into trunk. Maybe other changes have been done since I checked out.
- Commit if OK.
Thanks. Matthias
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Geotools-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
