A ParseWKT2GeoTiffMetadata class has been added to the
org.geotools.referencing.wkt package. I have two concern with it:
1) It introduces a dependency to beam.jar (a GeoTIFF library) which
is normaly not needed for module/referencing working. Would it be
appropriate to keep the class in plugin/geotiff for avoiding this
dependency before a user need it?
2) If my understanding is right, the intend of this class is to build
a set of GeoTIFF metadata. However it is not clear to me why this
task is performed during WKT parsing: it seems to mix two tasks in
a single class and add code duplication (the "normal" WKT parser,
and the special WKT parser which fill GeoTIFF metadata as a side
effect of WKT parsing). Would it be possible to create an other class
instead, completly disconnected to WKT parsing, which performs the
same tasks using type inspection (if x instanceof y)? For example:
if (crs instanceof ProjectedCRS) {
ProjectedCRS pCRS = (ProjectedCRS) crs;
metadata.addGeoShortParam(GeoTIFFCodes.ProjectedCSTypeGeoKey,
32767);
metadata.addGeoAscii(GeoTIFFCodes.GeogCitationGeoKey,
pCRS.getName().getCode());
Projection proj = pCRS.getConversion();
metadata.addGeoAscii(GeoTIFFCodes.PCSCitationGeoKey,
proj.getName().getCode());
// etc...
}
Martin.
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server.
Download it for free - -and be entered to win a 42" plasma tv or your very
own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
