Simone Giannecchini a écrit :
That code was used by james mcgill if I remember in the tests of the
streaming renderer. I substitued with another one which was actaull
working but I was curios about this one. If I make you waste time I am
sorry but I thought I had to check it anyway.
Dont worry, you are not making me waste my time; more tests is always
better, and it also point out area for improvement (e.g. the 'equals'
method below).
I noticed that StreamingRenderer tests use invalid CRS in a few places.
This is why I had to disable StreamingRenderer JUnit tests in the Maven
2 build, because those tests fail (our Maven 2 build executes tests with
assertions enabled - our Maven 1 build do not, which is why those
StreamingRenderer test bugs are unoticed with Maven 1). We would need a
volunter for fixing StreamingRenderer tests, but not before the coverage
branch merge I suggest.
I saw and checked this, I might suggest to enhance a bit the equality
testing in envelope equals using an EPS instead of a simple == which
on double and float values might lead to wrong results.
Agree. I will add an 'equals(Envelope, double eps)' method... (it may be
better to lets the users specify the 'eps' himself, since it is CRS and
axis-units dependent).
Martin.
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
