Martin Desruisseaux wrote:
Jody Garnett a écrit :
I would like to format up 2.2.x when it is released, and then stick
with it (aka format before every commit like the bad old days).
I have two issues with reformating:
1) We have at least two different coding rules in use. When we talked
about coding rule for the
whole Geotools project a few years ago, I really though that we
agreed on Sun's convention.
I had to change my way to code, because I was using slightly
different conventions. Now, I
see two differents way in Geotools code to put space around
parenthesis (for example).
for (int i=0; i<limit; i++) { // Sun coding convention
}
for( int i=0; i<limit; i++ ){ // I don't know where this
convention come from
}
Same apply to spaces in method call (Sun: method(argument);
Geotools: method( argument );),
while loops (Sun: while (condition); Geotools: while( condition
);), etc.
If we were to apply some reformating tool, at least I would like
that we choose Sun coding
convention...
Okay, can you review the setting used in Jalopy? I thought they were Sun
Conventions + GeoTools header...
I just want us to use a tool rather then argue about it...
2) I tend to align a lot of my code in tabular format. The is some
formating that an automatic
reformating tool can't figure out by itself. I know that there is
some way to guard block of
code against reformating, but guarded block would appears in a fear
amount of place, which
would defeat the purpose of code reformating...
So this would be a vote for doing nothing ...
Thanks for the feedback Martin, I want to vote +1 for formatting (and
format 2.2.x before release) or -1 for no formatting (and remove that
section from javadoc) - in both cases I will help move things forward. I
just don't want to do +0 and let this issue slide for another release.
Jody
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
