We realize that the quick fix that we made has much poorer performance than the original code. This code is used every time a number is read in a shapefile. Our implementation generates a new string for each number while the original code simply inspected the characters from the buffer while parsing the numbers. We have not been able to assess the performance difference, though. In any case, this part of the code should be studied more closely. The original NumberParser.java seemed to have some code that originated from FloatingDecimal (by Sun), but also a lot of it was written anew.
The original FloatingDecimal.java can be found in http://www.javaresearch.org/source/jdk142/java/lang/FloatingDecimal.java.html I did a quick comparison to find out that there, indeed, is enough common code to keep the copyright effective, but also I got a feeling that rewriting the NumberParser so that it no longer uses any Sun code would not be too big a task. Pertti >-----Original Message----- >From: ext Richard Gould [mailto:[EMAIL PROTECTED] >Sent: 18 April 2006 23:39 >To: Haggstrom Hans (Nokia-NET/Espoo); >geotools-devel@lists.sourceforge.net >Cc: Tapola Pertti (Nokia-NET/Espoo); [EMAIL PROTECTED] >Subject: Re: [Geotools-devel] GeoTools license information >incorrect in the Wiki > >Thanks for pointing this out. On trunk, the NumberFormat class >was moved to the referencing module. The only code in the >codebase that actually used it was DbaseFileReader.java. > >I have made the changes you provided to it. > >I have also deleted test/org/geotools/resources/NumberParserTest.java >and src/org/geotools/resources/NumberParser.java. > >Hopefully this does not screw anything else up. Andrea - Jody >mentioned that you may have said that it was used for >performance reasons? > >Cheers, > >Richard > > >[EMAIL PROTECTED] wrote: >> Hello, >> >> In the documentation in the GeoTools wiki the license for >GeoTools is >> described as LGPL ( >> _http://www.geotools.org/display/GEOT/1.4+Source+License_ ). >> >> However, on the sourceforge project page the licenses GPL, LGPL, and >> MIT are listed ( _http://sourceforge.net/projects/geotools/_ ). >> >> In the sources (for version 2.1.0), there seems to be both LGPL and >> GPL licensed code (based on license comments in files), as >well as one >> source file covered by the Sun license (NumberParser.java, >copied from >> an old version of the JDK perhaps?). The Sun license comment reads: >> >> * Copyright 2002 Sun Microsystems, Inc. All rights reserved. >> * SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. >> >> Could the Wiki page mentioning only LGPL be updated to reflect the >> licenses mentioned on the sourceforge page? (Or alternatively the >> code updated to only contain LGPL licensed code, althought >that is probably a >> more long term effort). Also, the Sun licensed file should >probably be >> replaced or at least investigated, as it seems to be >incompatible with >> GPL and LGPL. >> >> >> >> We wanted to use the main-2.1.0.jar and shapefile-2.1.0.jar with the >> LGPL license. Fortunately, these two Jars did only contain one unit >> test file and one html file that were GPL licensed, and the Sun >> licensed NumberParser.java (used for parsing some doubles from >> strings). We removed the test, html file, and >NumberParser.java. We >> had to replace the places where NumberParser.java was used (in >> DbaseFileReader.java) with (slower) calls to standard JDK >library methods. >> >> According to LGPL we make our changes to the code available in the >> attached file (it was the only changed source file). >> >> >> <<DbaseFileReader.java>> >> >> >> Best regards, >> >> -- Hans Häggström >> >> > > ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
