Hi Chris, As quoted from Chris Holmes <[EMAIL PROTECTED]>: > Any chance I could convince you to put this patch in the geoserver task > tracker? http://jira.codehaus.org/browse/GEOS I'm happy to submit it > myself, but if you do it then you'll be automatically notified when it's > updated.
Well ... I don't mind getting into this; the reason I sent in the patch is that I obviously don't want to keep my own version of this one method in this one class from GeoTools. However, I'm not quite sure how I should go about this (I read the hacking bit at http://www.geotools.org/display/GEOT/Hacking but it's unclear to me what the impact of e.g. keeping it in line with version 2.3 would be). So I guess the short of it is that at the moment it is more convenient for me if you submitted it yourself. But you might convince me anyway. ;-) > I'm slightly wary of this, as there's a chance it may break the CITE > conformance tests. Any way to run these (apart from the obvious "maven test" that was already run as part of my build)? > Mostly because the tests aren't good, not because > it's the wrong thing to do, but I remember that I thought nulls should > work this way, but that in their set up nulls were just returned as > blank. Dunno 'bout that. You don't see the problem if you use shapefiles, as there are no nulls there, just empty fields (which means you will get them as empty fields in the GML). With a real (hah!) database the difference is that you get this (slightly edited for brevity) GML *with* the patch: <wfs:FeatureCollection xsi:schemaLocation="[...]"> <gml:boundedBy> <gml:Box srsName="http://www.opengis.net/gml/srs/epsg.xml#4326";> <gml:coordinates decimal="." cs="," ts=" ">1.0,1.0 2.0,2.0</gml:coordinates> </gml:Box> </gml:boundedBy> <gml:featureMember> <xxx:yyy fid="yyy.38"> <xxx:name>test</xxx:name> <xxx:length xsi:nil="true"/> <xxx:width xsi:nil="true"/> <xxx:geom> <gml:Point srsName="http://www.opengis.net/gml/srs/epsg.xml#4326";> <gml:coordinates decimal="." cs="," ts=" ">1.5,1.5</gml:coordinates> </gml:Point> </xxx:geom> </xxx:yyy> </gml:featureMember> </wfs:FeatureCollection> as opposed to the *distributed* version: <wfs:FeatureCollection xsi:schemaLocation="[...]"> <gml:boundedBy> <gml:Box srsName="http://www.opengis.net/gml/srs/epsg.xml#4326";> <gml:coordinates decimal="." cs="," ts=" ">1.0,1.0 2.0,2.0</gml:coordinates> </gml:Box> </gml:boundedBy> <gml:featureMember> <xxx:yyy fid="yyy.38"> <xxx:name>test</xxx:name> <xxx:geom> <gml:Point srsName="http://www.opengis.net/gml/srs/epsg.xml#4326";> <gml:coordinates decimal="." cs="," ts=" ">1.5,1.5</gml:coordinates> </gml:Point> </xxx:geom> </xxx:yyy> </gml:featureMember> </wfs:FeatureCollection> which misses out the xxx:length and xxx:width attributes that are null in the database. > So to get this in to GeoServer correctly we may need to make it > a config option, or make a part of the 'citehacks' options. Is there something I could do to find out if this is really needed or not? Cheers, -- -- Gertjan van Oosten, [EMAIL PROTECTED], West Consulting B.V., +31 15 2191 600 ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
