Hey, so I just debugged some code that was leaving connections open.
It came down to the streaming renderer, to the new code that doesn't ask for FIDs. It made a new transaction, which made it so even if the reader was closed, the transaction would remain open.
I think what should be done in the future is that client code (aka GeoServer) should make the transaction and set the hint there, the renderer probably just shouldn't try fancy stuff like making a new transaction.
Of course if we had proper hints in Query then this wouldn't be an issue, since you wouldn't need to make a new transaction. The other option is to not have Transaction.AUTO_COMMIT be a singleton, if a new object was created each time then we could properly set hints...
Chris -- Chris Holmes The Open Planning Project http://topp.openplans.org
begin:vcard fn:Chris Holmes n:Holmes;Chris org:The Open Planning Project adr:;;377 Broadway, 11th Floor;New York;NY;10013;USA email;internet:[EMAIL PROTECTED] title:VP, Strategic Development x-mozilla-html:FALSE url:http://topp.openplans.org version:2.1 end:vcard
