Hello Jody
The review of epsg-access and epsg-postgresql look fine and I see nothing to
add.
One note about the readme.txt file in plugin/epsg-hsql: the instructions copied
from the javadoc are
actually for module maintainers; it explain how to upgrate the plugin for
latest EPSG database
release. Users doesn't need to care about them. Should I delete them from the
readme file? I will
try to make the javadoc clearer about the part that are for module maintainers.
Jody Garnett a écrit :
> I understand that the HSQL.html instructions is actually linked to by
> the package.html in referencing (as with the other epsg plugins). I have
> including a simple package.html with your module that you may choose to
> delete (on the off chance that javadocs are produced module by module).
Thanks for adding this package.html, I think that it is a good move and we
should keep them for the
"module by module" javadoc. For the cross-module javadoc, I guess that there is
some way to tell
Maven (maybe with a custom plugin if there is no standard way) that the
package.html file in some
"master" module should take precedence.
> My best guess it the difficult LICENSE.TXT wording is relative to the
> jdbc driver that is probably included in our download?
Yes.
> I could find no duplication of the wording in the header files for the
> module.
The gt2-epsg-hsql module do not contains any code derived from HSQL, so the
HSQL copyright do not
applies to the Geotools source code. I will update the review.txt file in order
to reflect that.
> Any clarification would be good. If we really do need to the indicated
> notification with our library we will need to provide instructions in
> the developers guide documenting how users of our library need to handle
> the situation (or simply drop the jdbc driver and a maven 2 file or
> download instructions for those wishing to use the hsql module).
If we wish to avoid the HSQL licensing, the only thing needed is to add
<scope>provided</scope> in
the <dependency> element relative to the HSQL engine. It would be less
convenient for user however,
since they would need to download the HSQL db themself.
I suggest to keep the HSQL engine bundled, and keep in mind that this
particular licensing apply
only to the binary release of plugin/epsg-hsql: it doesn't apply in any way to
the Java source code
in this module. Note that each module can have their own licensing page, e.g.:
http://maven.geotools.fr/reports/api/license.html
The current licensing page generated by Maven links to the license published on
the GNU web site. I
suggest to convert all "LICENSE.txt" files in Geotools into "LICENSE.html"
files (for nicer
formatting and capability to add hyperlink), and setup Maven 2 in order to
publish those
"LICENSE.html" files into generated pages like the above-mentioned one. I can
convert the
LICENSE.txt files in the modules that I maintain and setup Maven 2 on trunk if
people wish.
Martin.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
