Martin Desruisseaux ha scritto: > Good idea. We need to keep trace of the index creation however, if we don't > want to lost them the next time we will update the EPSG database (the > database > provided in epsg-hsql is supposed to be created from the SQL scripts > downloaded > from the EPSG site).
Too bad all the changes I done are sitting on my pc, at home, otherwise I would send you a diff... > Yes, the buffering wrapper class is supposed to cache the results. > > The axis were not cached because I was unhappy with the method signature > used in FactoryUsingSQL, namely: > > createCoordinateSystemAxis(String code, final int dimension) > > All other methods expect only a (String code) argument, and I though > that the above signature should not exists in a public API. However, if > profiling show that it is a performance botleneck, we can make a > compromise. This method would need to be public or at least protected > because BufferedAuthorityFactory is in a different package. I will do > this change and see what performance we can get (will try to keep it > protected). Than main problem is that the method is called by other methods such as operation building, so you'll have to make that parameter public in quite a bit of places I presume... > If you could fix the suboptimal queries on your side (problems in SQL > statements I presume?), that would be appreciated :). Well, cases where a subquery is faster than a join, especially when the subquery do really return a single value. Thought that may cause problems with old mysql database that do not support subqueries. I'm also assuming the hsql optimizer is not clever enough to notice the join is not necessary and convert the inner loop into a single database access. >> Maybe we could concentrate on speeding it up instead of removing tests? >> That would require some kind of internal axis number cache (maybe a >> flag stating that the database is immutable and thus can be freely >> cached). > > I will try to cache the axis and see what I get. Thanks for yours insight, Well, just to try out, maybe it's better to just setup a cache in the FactoryUsingSQL and think about changing all the rest if the results show there is a noticeable improvement. Cheers Andrea ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
