Chris Holmes wrote:

> Justin Deoliveira wrote:
>
>> Some recent development on geotools 2.2.x has caused filter encoding to
>> go bad...
>>
>> The pre vs post filter processing (used to be SQLUnpacker) appears to
>> have been totally rewritten. This is annoying for two reasons:
>>
>> 1. The postgis module maintainers (chris and I) were not consulted
>> before hand.
>
Please add yourself to the pom.  Some consultation took place, but 
certainly not enough.

>> 2. 2.2.x is supposed to be "stable" which means just bug fixes. This
>> goes far beyond that.
>>
>> I am not trying to point fingers, I am as much to blame as anyone as I
>> have not been keeping up with what is going on apparently.
>
My apologies -- I am to blame for this, but these changes are important 
(otherwise we are shipping with some significant flaws -- ie "stable", 
but broken).  Some changes were a little beyond just a bug fix... so 
three lashings with the pointy stick for me.

> I'm also a bit scared of the GEOS and non-GEOS postgis merge.  Not 
> because it doesn't need to be done, but because it has the possibility 
> of introducing some hard to find bugs.  'nice to have' changes on 
> things that are already working well and tested should _not_ be done 
> right before we're about to make a .0 release.  And I'd put the filter 
> capabilities stuff in the same category - we had a stable way of doing 
> things, if uDig requires a major change then they should be on the 
> next version.  And if we actually are able to get the api to calm down 
> we could theoretically just use a 2.3 jar for postgis with 2.2 for the 
> rest.

Fair enough.  A non-GEOS PostGIS still sounds pretty obscure to me -- 
the split was quite confusing.  I don't think this is risky since a 
non-GEOS PostGIS only supports SPATIAL_BBOX... so the code remains 
pretty much the same except it short circuits if there is no GEOS support.

Thanks for whacking those bugs Justin :)

Cory.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to