Justin Deoliveira wrote: >Sorry for the late reply, but this commit already went through I take it. >I was hoping to get a chance to review it first. With Chris bringing up >policy, I am having some issues with commit and ask questions later style >we seem to have adopted. > > Fair enough.... i'll try to stick to jira, e-mail (ask for permission), fix, get response, commit/submit patch.
>...the issue with JDBCDataStore >modifying the passed in query object in getFeatureReader. > >As module maintainer I would like to fix this, but since it has to do with >the filter splitting changes that were introduced, and I dont really know >that code, I dont feel comfortable doing so. > Ok... we'll have to look at this. >>One big thing missing though is parallel commits to trunk. We've been >>bad at this, and it wasn't something we talked about in switzerland - how >>to make sure we don't miss all kinds of bugs when we upgrade stable. We >>should get some kind of policy in place, but I thought I'd bring it up. >> >> I'm usually pretty good with this, but held off on this one as I ran out of time and didn't want to commit without running tests. Justin has volunteered to merge the changes to 2.3.x after the M0 release; I am merging to trunk right now, please see: http://jira.codehaus.org/browse/GEOT-954 and http://jira.codehaus.org/browse/GEOT-948 >>Cory Horner wrote: >> >> >>>Changes include: >>>- exposing the ConnectionPool (this is mostly so tests may obtain a >>>connection and create tables) >>>- PostgisDBInfo object (encapsulated >>>version info -- since several methods were asking postgis what version >>>it was, and it is better to just ask once) >>>- expanded PostgisTests utility >>>- GEOT-948: JDBC1DataStore is thread safe >>> ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
