Hi Cory, Nice work!! However one thing. I think it might make more sense to instead of having an offline profile, To have two profiles online, and extensive, and keep the current default profile behavious.
I say this because perhaps I want to make the default profile in my module something different for whatever reason, this means I have to specify offline as well. Basically in my opinion is makes sense to always by default ( no matter the profile ) have online and extensive tests disabled. -Justin Cory Horner wrote: > Howdy, > > I've just applied a change to the root pom, which sort of brings back > the -o option from maven 1. > > Rather than always excluding *OnlineTest.java from our suite of test > cases, this has been moved to a profile which we have the option of > enabling/disabling. At the moment, it is the default profile, so when > you execute "mvn install" the offline.mode profile is in use by default, > thus turning these tests off. If you specify a different profile > without also specifying the offline.mode profile (or having that profile > also apply the exclusion), online tests will be enabled. > > Should we adopt a naming convention for the three levels of tests? At > the moment we want: > > Level 1: quick sanity check (offline) > Level 2: a bit more (online) > Level 3: hit me with everything you've got (nightly, online) > > This has been touched on before in previous e-mails, but basically Level > 1 would be run by developers before they commit, level 2 would be run by > TOPP on each commit, and level 3 would be run by Refractions each > night. There are 2 environment variables extensives.tests and > interactive.tests, but these do not seem to be adopted -- and it seems a > lot easier to just adopt a naming scheme for extensive tests (but > interactive.tests could be useful). > > One naming scheme could be: > 1: *Test.java > 2: *OnlineTest.java > 3: *ExtensiveTest.java > > Thoughts? > > Cheers, > Cory. > > --- > > ...Below is the diff: > > Modified: geotools/trunk/gt/pom.xml > =================================================================== > --- geotools/trunk/gt/pom.xml 2006-11-02 23:27:59 UTC (rev 22574) > +++ geotools/trunk/gt/pom.xml 2006-11-03 00:00:25 UTC (rev 22575) > @@ -35,9 +35,13 @@ > <!-- reported by the surefire report --> > <!-- plugin. --> > <!-- --> > - <!-- Example: mvn -Pextensive.tests install --> > - <!-- mvn -Psite.build site --> > + <!-- offline.mode Disables tests which match the --> > + <!-- pattern *OnlineTest.java. --> > + <!-- (default profile) --> > <!-- --> > + <!-- Example: mvn -P extensive.tests install --> > + <!-- mvn -P site.build,offline.mode site --> > + <!-- --> > <!-- Note that profiles like "site.build" are not mandatory --> > <!-- for using the "site" goal. Such profiles just modify --> > <!-- the build process prior the "site" goal execution in a --> > @@ -72,6 +76,24 @@ > <extensive.tests>true</extensive.tests> > </properties> > </profile> > + <profile> > + <id>offline.mode</id> > + <activation> > + <activeByDefault>true</activeByDefault> > + </activation> > + <build> > + <plugins> > + <plugin> > + <artifactId>maven-surefire-plugin</artifactId> > + <configuration> > + <excludes> > + <exclude>**/*OnlineTest.java</exclude> > + </excludes> > + </configuration> > + </plugin> > + </plugins> > + </build> > + </profile> > </profiles> > > > @@ -93,7 +115,7 @@ > </scm> > > <description> > - Welcome to the homepage of the GeoTool build process > + Welcome to the homepage of the GeoTools build process > In the left side bar you should see a list of active modules, > visit each for more details on the status of each module. > </description> > @@ -895,9 +917,6 @@ > <includes> > <include>**/*Test.java</include> > </includes> > - <excludes> > - <exclude>**/*OnlineTest.java</exclude> > - </excludes> > <forkMode>once</forkMode> > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,454a8bd3109052051017194! > -- Justin Deoliveira The Open Planning Project [EMAIL PROTECTED] ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
