Okay Justin that is everything I can think of: - http://docs.codehaus.org/display/GEOTOOLS/Expression+Improvements
Someone has updated the acceptance tests with boolean and string examples - thanks!. The remaining feedback I am looking for is: - good date examples for the acceptance tests (Gabriel?) - feedback on PropertyAccessor - feedback on the TypeMorph - consider LiteralHandler as extension of TypeMorph, and account for date format as part of "context" when encoding Cheers, Jody > The four binary math operation implementations, > AddImpl,SubtractImpl,MultiplyImpl,DivideImpl always return a floating > point value. For the first three I would think that if both the operands > are in the integer value space, then the result should also be. > > The operations delegate to Filters.number( Object ) to get numeric > values from an expression, which returns a primitive double. I suggest > we make them smarter and have them try to convert the values to integers > first. So I propose the following changes to the Filters utility class: > > 1. Add a method called Filters.asNumber( Expression ), which returns a > java.lang.number. The method should try to parse the expression as an > Integer first, if that fails then parse the expression as a Double. > > 2. Remove number(), and people that call number should be calling > asDouble(), making them explicity ask for a floating point value. > > -Justin > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
