Gabriel can I propose a more radical "fix" -- on the geotools devel list for now.
GEOT-1038: > In the move to the GeoAPI filter interfaces, most FunctionExpressions > got broken by improper delegation to the new methods. > For example, some keep storing their arguments in an Expression[] > field, while not properly delegating to getParameters(). Since the FilterFactory implementations do not let you create implementations without both Expression filled in; can we remove setParameters and make getParameters return an unmodifiable list. This would render the Filter/Expression interface immutable which would simplify the FIlter transformations we make when prepping for SLD or SQL generation. The user community on GeoAPI has largely vanished; and for some Filters (like "like") the range of data values is not fully represented by setter methods anyways. two cents; Jody > Hi all, > > as you may see in http://jira.codehaus.org/browse/GEOT-1038, almost all > FunctionExpression implementations in trunk are broken. > > I'm working on fixing it, but since it means modifying like 130 classes, I > want to ask the responsibles for direction: should I fix and commit, provided > that the test cases I wrote, which exposes 373 bugs, all pass; or should I > send a patch? > > btw, since most Functions inherit from FunctionExpressionImpl, the fix for > them is just to remove its internal Expression[] fields and properly delegate > to the superclass methods, which already take care of making the deprecated > methods play nice with the new ones from the GeoAPI Function interface. > > Regards, > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
