Thanks Martin; I was trying to think of a place to talk about the equals
+ hashcode contract and you beat me too it. Makes me happy.
I have modified the page to place {warning:tilte=NAME OF PROBLEM} around
the code examples you provided that were examples of what not to do.
The specifics of how an why this was a bad idea have to do with local
specific code; although I can talk about this need during Monday's
meeting - providing an application specific localization is something we
are going to need to do for the datastore connection process (so uDig
users can see problems expressed along with advice on how to fix). I
would really like your feedback on this as your modules are the only
ones with full internationalization support as far as I know.
Jody
> The locale-dependent build failure was caused by ArcGridReader (lines 524 and
> 526) creating a Category named exactly "No Data", and ArcGridWriter looking
> for
> a category named "No Data" in locale language, which is "Absence de données"
> in
> French - concequently the matching fail in that language. It didn't fail for
> other languages because French is currently the only non-English language
> that
> provides localization for every keys in the org.geotools.resources.i18n
> package.
> Other languages fallback to English.
>
> The problem was caused by a slight inconsistency. It is okay if we use the
> localized name everywhere (including both ArcGridReader and ArcGridWriter),
> or
> the non-localized name everywhere. But both were mixed.
>
> I created a wiki page with some of the things I'm looking for:
>
> http://docs.codehaus.org/display/GEOT/5.1.5+Avoid+assumptions
>
> A applied some of them to the 2.3 branch and trunk. Not everywhere however;
> some
> coverage plugins need more though. In some place I just put the suggested
> code
> in comments, waiting for a tester to uncomment it.
>
> The work on coverage is still in progress...
>
> Martin
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
